Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FYI issues when [ or ] is in file or folder name #331

Open
scottdunnflux opened this issue Jul 26, 2016 · 6 comments
Open

FYI issues when [ or ] is in file or folder name #331

scottdunnflux opened this issue Jul 26, 2016 · 6 comments

Comments

@scottdunnflux
Copy link

My bucket contains folders whose name contains both a [ and a ]

While browsing the bucket the following is fine
http://s3auth.example.com/AMCopyObjects/September%202016_6824718/Well_64/

But we get an error when clicking on a folder on that page that uses the following uri:
http://s3auth.example.com/AMCopyObjects/September%202016_6824718/Well_64/Layout%20[Print]_7348007/index.html

Error message is:
request URI is not encoded correctly: java.net.URISyntaxException: Illegal character in path at index 57: /AMCopyObjects/September%202016_6824718/Well_64/Layout%20[Print]_7348007/index.html
It stops there but I think it would choke at 63 as well.

According to my research the URI should be something like
/AMCopyObjects/September%202016_6824718/Well_64/Layout%20%5BPrint%5D_7348007/index.html

@davvd
Copy link

davvd commented Aug 1, 2016

@yegor256 please dispatch this issue

@scottdunnflux
Copy link
Author

And, as long as we're talking about URI encoding issues, check for cases where file names include a semicolon
This doesn't produce the same error, but the URI is improperly formed.
In my case s3auth shows something like
http://amk4s3.aws.fluxconsulting.com/AMK4Export/July_August%202014_2406031/Layout%20_Print__7348007/0714_WEL_Yager_Creative_3667028/0714_WEL_Yager_CreativeProces_3667028;63.indd.gz
when it should show %3B for the ;

@yegor256
Copy link
Owner

yegor256 commented Aug 8, 2016

@scottdunnflux good question... we're just using the URI provided as is. This means that you have to encode everything before giving us the URI. We don't touch it, we just send it to AWS "as is". Or I didn't understand the problem?

@scottdunnflux
Copy link
Author

We're not sending any URLs to the S3 bucket, only files and folders...

Here's an example of the URL I'm seeing at AWS:
image

And here's the source html of the s3auth page that shows the same file where the URL is different.

This is page is auto-generated by s3auth.com

prefix: NJDK4Export/January 21, 2015_2746522/Layout_3692634/0121LAYOUT p7 grain_2776738/

Name Size (bytes)

NJDK4Export/January 21, 2015_2746522/Layout_3692634/0121LAYOUT p7 grain_2776738/0121 grain_2776959_6/

NJDK4Export/January 21, 2015_2746522/Layout_3692634/0121LAYOUT p7 grain_2776738/0121LAYOUT p7 grain_2776738;4.indd.gz

3918628

@scottdunnflux
Copy link
Author

Looks like that source didn't make it as intended, but you can still see how the URL comes across through s3auth.

@yegor256
Copy link
Owner

@scottdunnflux I'm sorry this bug is still not fixed. We didn't have enough funds/time to work on the project. However, recently we received some donations from our grateful users and will continue to fix issues and introduce new features. Would be great if you can also donate -- to help us move forward faster. Here is the link: https://www.0crat.com/contrib/C3RP1J1CH

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants