Expires.Hour does nothing

[monomonedula]

Expires.Hour class does absolutely nothing. It does not modify the behavior of the object it wraps in any way.

Is this intended behavior? If so, what's the purpose of this class?

takes/src/main/java/org/takes/misc/Expires.java

Lines 100 to 103 in 925e1a2

	@Override
	public String print() {
	return this.origin.print();
	}

[andreoss]

@monomonedula

It's not possible to use Expires header for relative expiration time (which seems to be an intent here) .
Cache-Control should be used instead
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control#expiration

And the main use case for Expires.Date looks like that:

            new Expires.Date(
                System.currentTimeMillis()
                    + TimeUnit.HOURS.toMillis(1L)
            )

So a proper solution would be to implement Cache-Control header, or at least complete Expires.Hour implementation with Expires.Date as a base class

@paulodamaso WDYT?