RqLive wrongly assumes the stream has ended when no data is aviable

[laeubi]

org.takes.rq.RqLive.data(InputStream, Opt<Integer>, boolean) has the following code

takes/src/main/java/org/takes/rq/RqLive.java

Lines 183 to 185 in 20467cf

	} else if (available && input.available() <= 0) {
	ret = new Opt.Single<>(-1);
	} else {

this is wrong, as it indicates that the stream has reached EOF but it simply means the buffer is empty. See also the javadoc here:

Returns an estimate of the number of bytes that can be read (or skipped over) from this input stream without blocking, which may be 0, or 0 when end of stream is detected.

So in case of 0 return value one can simply not tell anything, so at best one can return EMPTY here.

But looking at the code I don't see how this ever is useful in the parsing here, as even if the buffer is empty now, all one can do is to wait for one byte so blocking I/O seems the only option here.

Another pitfall is that here:

takes/src/main/java/org/takes/rq/RqLive.java

Line 73 in 20467cf

while (data.get() > 0) {

it assumes EOF also when the read byte is == 0, even though it should not happen and is an error in the http stream, a zero byte can be read from a stream and is not an EOF!