-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 1303 solved. #1330
Issue 1303 solved. #1330
Conversation
@UFA-MOROZOV how do know it's solved? Maybe you can create a unit test that reproduces the problem first? |
@yegor256, i used this test that i added in ChunkedInputStreamTest locally(Before my changes in code it didn't work as was stated in issue):
|
@yegor256, i can add this test to corresponding file in repository, but i don't think it's necessary, since it not so common issue in most cases. |
@UFA-MOROZOV we usually don't make changes without tests that confirm that the changes are needed |
|
@UFA-MOROZOV now it looks very good. However, the formatting of the code is a bit off. See what |
@yegor256 i refactored code and ran qulice, now it is alright. |
@rultor merge |
@UFA-MOROZOV thanks! |
@yegor256, please review