Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test cleanup: deprecate.test.ts #1489

Merged
merged 8 commits into from
Nov 8, 2023
Merged

Test cleanup: deprecate.test.ts #1489

merged 8 commits into from
Nov 8, 2023

Conversation

weedySeaDragon
Copy link
Contributor

@weedySeaDragon weedySeaDragon commented Nov 3, 2023 •
edited
Loading

  • added TODO for changing deprecate.js to deprecate.ts (as a reminder and to note which lines can be changed (improved) when that happends
  • added types (SinonSpy, a type for the object used for testing)
  • created separate tests for:
    • testing deprecated functions
    • testing deprecated objects
      • properties
      • functions
  • change the word 'wrapped' so that it's clear what is happening (deprecation)

part of cleaning up tests #1481

@mshima mshima merged commit 0add881 into yeoman:main Nov 8, 2023
3 of 4 checks passed
This was referenced May 25, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshima mshima mshima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weedySeaDragon @mshima