Skip to content
This repository has been archived by the owner on Mar 5, 2019. It is now read-only.

Pinned tabs appear on top of regular tabs #12

Closed
hackel opened this issue Mar 9, 2015 · 7 comments
Closed

Pinned tabs appear on top of regular tabs #12

hackel opened this issue Mar 9, 2015 · 7 comments
Labels

Comments

@hackel
Copy link

hackel commented Mar 9, 2015

This may have been related to 4da116f. When I pin a tab, my non-pinned tabs move all the way to the left, and the pin tab appears on top of them, with it's icon actually appearing to the right of the unpinned tab beneath it.

@yfdyh000
Copy link
Owner

Multi-line Tabbar enabled? I see the similar problem on Fx28 + Original TU, so this is a bug / feature in Original TU?
I saw the pinned tabs occupation a separate line when the Multi-line Tabbar option enabled and the non-pinned tabs width overflow.

Can you attach a screenshot? I don't understand the "with it's icon actually appearing to the right of the unpinned tab beneath it."

@hackel
Copy link
Author

hackel commented Mar 10, 2015

No, I don't use the multi-line tabbar. I beleve it was present in the original TU as well, once Australis came out.

pinned tab

In the first image, I have the pinned tab (gmail icon) selected. Second image, the first non-pinned tab is selected (regular google icon), and third, another tab is selected, and you can see the icon placement. If I enable the "Left extra space" option, then both icons line up on top of each other.

@yfdyh000
Copy link
Owner

Thanks for the report, I see the problem when switching the "Left extra space" option.

@yfdyh000 yfdyh000 added the bug label Mar 10, 2015
@hackel
Copy link
Author

hackel commented Mar 10, 2015

Sorry, just want to clarify, in the screenshots above, the "left extra space" option was not enabled. I was saying that if I do turn it on, then both icons appear exactly horizontally aligned. Oddly, at the moment it seems to have fixed itself and my pinned tab (now added a second) are working perfectly. Unless you pushed a new version I didn't notice!

@yfdyh000
Copy link
Owner

Thanks for the added, I did not to push a new version (and currently it cannot be silent update).

I see the problem when enabled the option, pin a tab, then disable the option, in seems any Firefox + any TU. The issue will be temporarily eliminate if I press the Alt key to trigger the menu bar, or call the this.positionPinnedTabs() a.k.a. gBrowser.mTabContainer.positionPinnedTabs()

@spvkgn
Copy link

spvkgn commented Mar 19, 2015

I have the same issue with latest release 2015.03.09-fix
with previous version 2015.02.19-2 this issue does not occurs. FF33

tabutils-pinned

@yfdyh000
Copy link
Owner

yfdyh000 commented Jul 5, 2015

@yfdyh000 yfdyh000 closed this as completed Jul 5, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants