Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add style argument to include_url() #1648

Closed
jvcasillas opened this issue Dec 20, 2018 · 3 comments
Closed

Add style argument to include_url() #1648

jvcasillas opened this issue Dec 20, 2018 · 3 comments
Milestone

Comments

@jvcasillas
Copy link

I would like to suggest including a style argument to the function include_url(). By default iframes include a rather ugly border around the object that is embedded. I propose including a style argument so that something like style="border:none;" can be included. If this is something that would be desirable, I would be more than happy to submit a pull request, though I don't know where include_url lives.

@yihui
Copy link
Owner

yihui commented Dec 20, 2018

This sounds like a reasonable feature request to me, but I don't have time for it. If you want to disable iframe borders globally, you could just define it in CSS like (I think you certainly know it):

iframe {
  border: none;
}

@yihui yihui added this to the v1.21 milestone Feb 15, 2019
@yihui yihui modified the milestones: v1.21, v1.22 Mar 5, 2019
@yihui yihui closed this as completed in bc47af0 Mar 7, 2019
@yihui
Copy link
Owner

yihui commented Mar 7, 2019

Done. Example:

```{r, out.extra='style="border: none;"', out.width='100%'}
knitr::include_url('https://yihui.name')
```

I think you still want to do it in CSS because that's cleaner.

@github-actions
Copy link

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue by following the issue guide (https://yihui.org/issue/), and link to this old issue if necessary.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants