Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font has changed in new version #404

Open
omzy opened this issue Mar 18, 2019 · 6 comments
Open

Font has changed in new version #404

omzy opened this issue Mar 18, 2019 · 6 comments
Labels
help wanted status:ready for adoption Feel free to implement this issue. type:enhancement Enhancement

Comments

@omzy
Copy link

omzy commented Mar 18, 2019

I've just updated to version 2.1.0 and now the font looks horrible :(

image

Looks like it is using Verdana:

image

From what I can see, Bootstrap 4 doesn't use Verdana as default, so not sure why this font is being used here. Same issue occurs in the Debug Toolbar.

@samdark
Copy link
Member

samdark commented Mar 18, 2019

What font would you prefer?

@omzy
Copy link
Author

omzy commented Mar 18, 2019

The one used in the previous version was fine to be honest (it may have been Arial). Either way that Verdana font is really old school - I don't think anyone uses it anymore.

In Bootstrap 4 it looks like the font stack begins with the system fonts and then uses custom fonts after that. The font size looks a bit small once you remove Verdana, so may need to have a play with the font sizes as well.

@machour machour self-assigned this Mar 23, 2019
@samdark samdark added help wanted type:enhancement Enhancement status:ready for adoption Feel free to implement this issue. labels Jul 16, 2019
@jkovacsab
Copy link

Related to this issue, I upgraded from 2.0.8 to 2.1.0 and noticed the font size shrank drastically (hard to read).
Also, the Diff pop-up lost its green and red line formatting, with only black text and gray rows, when I know there are changes and can see 'ins' tags available.
Can I do anything to bring back the previous formatting? I only see a main.css loading, should there be any bootstrap css files?
In the 2.1.0 changelog, I see "Create (bootstrap)-independent version". Is that change related to these problems?

@samdark
Copy link
Member

samdark commented Jul 22, 2019

Yes. Bootstrap was upgraded to v4 and bundled with the extension itself.

@jkovacsab
Copy link

Thanks for the quick reply. I do see the Bootstrap css classes built into the main.css. I deleted the specific web/assets folder, it regenerated, and that seemed to bring back the red and green diff lines. However, it did not help the excessively small [to me] body font-size of .75rem, coming from _reboot.scss. Why is that used, and am I missing something to get back to the default look and feel from 2.0.8?

@samdark
Copy link
Member

samdark commented Jul 22, 2019

Defaults changed in Bootstrap 4. We've managed to tweak most of the styles to look identical to what they were before but it seems not all of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted status:ready for adoption Feel free to implement this issue. type:enhancement Enhancement
Projects
None yet
Development

No branches or pull requests

4 participants