-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ts definitions on javascript file not working #129
Comments
I don't have much experience with lsp's (never wrote anything related to it, just used them) but I'd be glad to try helping solving this . Let me know if you need anything |
Could you check if other LSP features like hover doc work normally? Does the basic completion for keywords like |
I might have failed to explain the problem more clearly: lsp features are working fine, but when using vtsls with javascript files specifically (not typescript files) there are no type definitions. |
I think this is the same issue: microsoft/vscode#196554, should be fixed in HEAD (not released yet). You can set |
I don't really have a tsconfig file since it's a js only project =/ But I'll see if I can figure something else out. Thanks! One other thing: I tested opening up vscode on the same project here and in vscode the type definitions are loading file, at least in vscode 1.85.1 (commit 0ee08df0cf4527e40edc9aa28f4b5bd38bbff2b2) Maybe vtsls is using an older lsp version than what this vscode version uses? |
Yes, the last syncing to VSCode of the current latest release version of vtsls is at #108, which is before the fix landed on the upstream: microsoft/vscode@60182c7. The next release should fix this. |
This happens when working with some nodejs libraries in a js project. Steps to reproduce:
now open main.js and import App from slack bolt
When using tsserver this gives us proper type definitions for all properties, but when using with vtsls we get nothing.
The text was updated successfully, but these errors were encountered: