Merge branch 'master' of github.com:yitzchak/common-lisp-jupyter

yitzchak · Oct 14, 2023 · d969204 · d969204
2 parents bdbbf49 + 7a7a916
commit d969204
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 4 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -70,7 +70,7 @@ jobs:
         pip install dist/pytest_jupyter_kernel-0.1.0-py3-none-any.whl
 
     - name: Checkout repository
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
 
     - name: Download Quicklisp
       run: |

diff --git a/debugger-restarts/package.json b/debugger-restarts/package.json
@@ -42,9 +42,9 @@
   "devDependencies": {
     "@jupyterlab/builder": "^4.0.1",
     "@typescript-eslint/eslint-plugin": "^6.3.0",
-    "@typescript-eslint/parser": "^4.8.1",
+    "@typescript-eslint/parser": "^6.7.0",
     "eslint": "^8.26.0",
-    "eslint-config-prettier": "^6.15.0",
+    "eslint-config-prettier": "^9.0.0",
     "eslint-plugin-prettier": "^5.0.0",
     "npm-run-all": "^4.1.5",
     "prettier": "^3.0.1",

diff --git a/docs/install.md b/docs/install.md
@@ -92,7 +92,7 @@ is installed add common-lisp-jupyter via `(ql:quickload :common-lisp-jupyter)`.
   `(ql:update-dist "quicklisp")` inside a `ros run` shell to resolve package
   conflicts.
 
-- Add the PATH in the initialization file (such as `~/.bashrc`)
+- Add the PATH in the initialization file (such as `~/.bashrc`- if using `jupyter-hub`, see **note** below)
 ```sh
 export PATH=$PATH:~/.roswell/bin
 ```
@@ -102,6 +102,18 @@ export PATH=$PATH:~/.roswell/bin
 ros install common-lisp-jupyter
 ```
 
+**note:** if using jupyter-hub's default set-up:  
+* You must run the `ros install common-lisp-jupyter` command for each user who will use lisp.
+* Edit `/home/${USER}/.local/share/jupyter/kernels/common-lisp/kernel.json`, adding:
+
+```json
+"env": {
+  "PATH": "${PATH}:${HOME}/.roswell/bin"
+}
+```
+
+so that jupyter-lab can find the lisp binaries. Note: `~/.roswell/bin` will not expand properly.
+
 ### Running common-lisp-jupyter
 
 common-lisp-jupyter may be run from a local installation in console mode by the