Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails on 2020-10-04 #60

Closed
zesterer opened this issue Nov 7, 2020 · 5 comments
Closed

Build fails on 2020-10-04 #60

zesterer opened this issue Nov 7, 2020 · 5 comments

Comments

@zesterer
Copy link
Contributor

zesterer commented Nov 7, 2020

   Compiling vek v0.12.0 (/home/joshua/Projects/vek)
error: expected `,`
   --> src/bezier.rs:428:30
    |
428 |             pub start: $Point<T>,
    |                              ^
...
834 |     impl_all_beziers!{repr_simd}
    |     ---------------------------- in this macro invocation
    |
    = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error: expected `,`
   --> src/bezier.rs:428:30
    |
428 |             pub start: $Point<T>,
    |                              ^
...
834 |     impl_all_beziers!{repr_simd}
    |     ---------------------------- in this macro invocation
    |
    = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error: expected `,`
   --> src/bezier.rs:612:30
    |
612 |             pub start: $Point<T>,
    |                              ^
...
834 |     impl_all_beziers!{repr_simd}
    |     ---------------------------- in this macro invocation
    |
    = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error: expected `,`
   --> src/bezier.rs:612:30
    |
612 |             pub start: $Point<T>,
    |                              ^
...
834 |     impl_all_beziers!{repr_simd}
    |     ---------------------------- in this macro invocation
    |
    = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error: expected `,`
   --> src/bezier.rs:428:30
    |
428 |             pub start: $Point<T>,
    |                              ^
...
839 |     impl_all_beziers!{repr_c}
    |     ------------------------- in this macro invocation
    |
    = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error: expected `,`
   --> src/bezier.rs:428:30
    |
428 |             pub start: $Point<T>,
    |                              ^
...
839 |     impl_all_beziers!{repr_c}
    |     ------------------------- in this macro invocation
    |
    = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error: expected `,`
   --> src/bezier.rs:612:30
    |
612 |             pub start: $Point<T>,
    |                              ^
...
839 |     impl_all_beziers!{repr_c}
    |     ------------------------- in this macro invocation
    |
    = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error: expected `,`
   --> src/bezier.rs:612:30
    |
612 |             pub start: $Point<T>,
    |                              ^
...
839 |     impl_all_beziers!{repr_c}
    |     ------------------------- in this macro invocation
    |
    = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error: aborting due to 8 previous errors

error: could not compile `vek`

To learn more, run the command again with --verbose.
@yoanlcq
Copy link
Owner

yoanlcq commented Nov 7, 2020

Hi, thanks for reporting this, I'll look into this ASAP.

@zesterer
Copy link
Contributor Author

zesterer commented Nov 7, 2020

Thanks. This is confusing the heck out of me. cargo expand doesn't seem to show any bizarre code generation going on.

@yoanlcq yoanlcq closed this as completed in f756410 Nov 7, 2020
@yoanlcq
Copy link
Owner

yoanlcq commented Nov 7, 2020

Whoops I didn't mean to close this yet. I've submitted a workaround here. I'd like to see if CI builds successfully as well.

The workaround was to put the structs in their own isolated module, and then define a type Point<T> = $Point<T>, then replace all refs to $Point<T> with Point<T>.

However I do think that we should report this as a bug to the relevant team; basically, an update broke the build "for free" and I suspect too few people had the same problem.

@yoanlcq yoanlcq reopened this Nov 7, 2020
@yoanlcq
Copy link
Owner

yoanlcq commented Nov 7, 2020

Well this looks fixed. One AppVeyor job choked on a connection error for whatever reason.
I've published version 0.12.1 with the fix, hopefully this does the trick.

About reporting the bug to the Rust repo, I wish to do it sometime soon, provided that I don't forget about it...

@yoanlcq yoanlcq closed this as completed Nov 7, 2020
@zesterer
Copy link
Contributor Author

zesterer commented Nov 7, 2020

Thanks very much for the responsive fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants