Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with latest nightly toolchain version #95

Merged
merged 1 commit into from
May 13, 2024

Conversation

crabm4n
Copy link
Contributor

@crabm4n crabm4n commented May 9, 2024

Platform intrinsics were removed and are replaced with core_intrinsics (now accessible via std::intrinsics::simd).

This is a breaking change as the simd_llvm and simd_traits which were publicly exported are removed.

Platform intrinsics were removed and are replaced with `core_intrinsics`
(now accessible via `std::intrinsics::simd`).
@xMAC94x
Copy link
Contributor

xMAC94x commented May 12, 2024

Hi @yoanlcq this MR is necessary for the veloren team to update the rust toolchain and newer toolschains had become incompatible with vek . do you have some time for a review?
best regards,
Marcel

@yoanlcq
Copy link
Owner

yoanlcq commented May 13, 2024

Hey guy, sorry for the delay! It's been a long 5-day week-end here in France.

This looks good to me. I was about to ask whether there was any way to be backwards compatible with prior compiler versions, but I guess there's no point: SIMD was always unstable and required explicit opt-in by using Nightly and enabling the platform_intrinsics feature. Plus, previous versions of vek are always available.

Thank you @crabm4n for your effort, I very much appreciate it.
You have waited long enough, so I'll merge this right now, then push a new version. If you'd like to add yourself to the list of contributors (README + Cargo.toml) then feel free to do so even in a separate PR.

@yoanlcq yoanlcq merged commit 5894cc5 into yoanlcq:master May 13, 2024
1 check passed
@crabm4n
Copy link
Contributor Author

crabm4n commented May 13, 2024

Thank you and no worries for the delay ;D

@yoanlcq
Copy link
Owner

yoanlcq commented May 13, 2024

This is now available in version 0.17.0 along with many warning fixes.

@xMAC94x
Copy link
Contributor

xMAC94x commented May 14, 2024

Thank you very much. No worries, we all have a personal live that matter first. Waiting a few days is absolutely no issue :)
Hope you enjoyed the long and sunny weekend :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants