Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple paragraphs #1

Open
th-km opened this issue Feb 13, 2019 · 3 comments
Open

multiple paragraphs #1

th-km opened this issue Feb 13, 2019 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@th-km
Copy link

th-km commented Feb 13, 2019

The plugin looks really useful, espacially for utility and component classes. I'm wondering if there is a way to add support for mulitple paragraphs styling? So far, it only returns the first paragraph.

Ideally something like this $page->title()->ktw('p', ['class' => 'custom']) would returns:

<p class="custom">...</p>
<p class="custom">...</p>
<p class="custom">...</p>
...
@th-km
Copy link
Author

th-km commented Feb 22, 2019

@yoanmalie any update on this?

@yoanmalie
Copy link
Owner

@th-km Hi, sorry for the lack of reply, I was on vacation.

Thank for your suggestion, that's I totally agree. I will give a look on how to do it properly. I have some questions to clear out, like sometime we only have to change the first one, or sometime all (that's what you want). So we maybe need another one parameter…

Since I'm not a PHP developer, I can't tell you that I will be done asap.
To anyone who's read this, feel free to help me on this.

By the way, I'm aware of this PR getkirby/kirby#1442 and I will probably have some breaking changes to do in the future depending on what and how they'll do it exactly.

@th-km
Copy link
Author

th-km commented Feb 26, 2019

Yeah I know, It's has always been difficult for me to style markdown and avoid things like this in my css:

p + p {
margin-top: 1.5rem;
}

I use toStructure()a lot without any decent alternative.

It'd be great to have acces to mutilple vars instead of one, basically all tags provided by markdown, with a default to null if nothing is specified. This will allow to style every tags the way you want (BEM, utility and so on).

@yoanmalie yoanmalie added the help wanted Extra attention is needed label Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants