Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working on new repository with domain containing a - #62

Closed
yoannfleurydev opened this issue Mar 23, 2021 · 1 comment
Closed

Not working on new repository with domain containing a - #62

yoannfleurydev opened this issue Mar 23, 2021 · 1 comment
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@yoannfleurydev
Copy link
Owner

Describe the bug

To Reproduce
Steps to reproduce the behavior:

  1. Add a remote with a domain containing a -
  2. Run gitweb using that remote
  3. See error
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Unable to get remote parts, please open an issue as it might come from the code', /Users/yfleury/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/gitweb-0.3.0/src/lib.rs:164:75
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Expected behavior
The program should open the remote repository.

Screenshots

image

Additional context
The regex used to get the remote parts is becoming insane, it is maybe time to think to use a tool like https://docs.rs/url/2.2.1/url/ to get the parts

@yoannfleurydev yoannfleurydev added the bug Something isn't working label Mar 23, 2021
@yoannfleurydev yoannfleurydev self-assigned this Mar 23, 2021
@yoannfleurydev yoannfleurydev added the good first issue Good for newcomers label Mar 23, 2021
@yoannfleurydev
Copy link
Owner Author

Working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant