No longer pass the complete callbacks object, but only the savescores…

… function, since only this is used in the scoreFormatter.
Yoast · Oct 5, 2015 · 9473dce · 9473dce
1 parent 116bdfd
commit 9473dce
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/dist/yoast-seo.js b/dist/yoast-seo.js
@@ -1288,7 +1288,7 @@ YoastSEO.App.prototype.runAnalyzer = function() {
 		this.config.targets.output,
 		this.config.targets.overall,
 		this.rawData.keyword,
-		this.callbacks
+		this.callbacks.saveScores
 	);
 
 	if ( this.config.dynamicDelay ) {
@@ -2139,14 +2139,14 @@ YoastSEO = ( "undefined" === typeof YoastSEO ) ? {} : YoastSEO;
  * @param {YoastSEO.App} args
  * @constructor
  */
-YoastSEO.ScoreFormatter = function( scores, overallScore, outputTarget, overallTarget, keyword, callbacks ) {
+YoastSEO.ScoreFormatter = function( scores, overallScore, outputTarget, overallTarget, keyword, saveScores ) {
 	this.scores = scores;
 	this.overallScore = overallScore;
 	this.outputTarget = outputTarget;
 	this.overallTarget = overallTarget;
 	this.totalScore = 0;
 	this.keyword = keyword;
-	this.callbacks = callbacks;
+	this.saveScores = saveScores;
 	this.outputScore();
 	this.outputOverallScore();
 };
@@ -2199,7 +2199,7 @@ YoastSEO.ScoreFormatter.prototype.outputOverallScore = function() {
 	if ( this.keyword === "" ) {
 		overallTarget.className = "overallScore " + this.scoreRating( "na" );
 	}
-	this.callbacks.saveScores( this.overallScore );
+	this.saveScores( this.overallScore );
 };
 
 /**

diff --git a/dist/yoast-seo.min.js b/dist/yoast-seo.min.js
diff --git a/js/app.js b/js/app.js
@@ -415,7 +415,7 @@ YoastSEO.App.prototype.runAnalyzer = function() {
 		this.config.targets.output,
 		this.config.targets.overall,
 		this.rawData.keyword,
-		this.callbacks
+		this.callbacks.saveScores
 	);
 
 	if ( this.config.dynamicDelay ) {

diff --git a/js/scoreFormatter.js b/js/scoreFormatter.js
@@ -9,14 +9,14 @@ YoastSEO = ( "undefined" === typeof YoastSEO ) ? {} : YoastSEO;
  * @param {YoastSEO.App} args
  * @constructor
  */
-YoastSEO.ScoreFormatter = function( scores, overallScore, outputTarget, overallTarget, keyword, callbacks ) {
+YoastSEO.ScoreFormatter = function( scores, overallScore, outputTarget, overallTarget, keyword, saveScores ) {
 	this.scores = scores;
 	this.overallScore = overallScore;
 	this.outputTarget = outputTarget;
 	this.overallTarget = overallTarget;
 	this.totalScore = 0;
 	this.keyword = keyword;
-	this.callbacks = callbacks;
+	this.saveScores = saveScores;
 	this.outputScore();
 	this.outputOverallScore();
 };
@@ -69,7 +69,7 @@ YoastSEO.ScoreFormatter.prototype.outputOverallScore = function() {
 	if ( this.keyword === "" ) {
 		overallTarget.className = "overallScore " + this.scoreRating( "na" );
 	}
-	this.callbacks.saveScores( this.overallScore );
+	this.saveScores( this.overallScore );
 };
 
 /**