Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Rename Kv to Chamelon_kv #14

Open
reynir opened this issue Aug 31, 2022 · 2 comments
Open

Suggestion: Rename Kv to Chamelon_kv #14

reynir opened this issue Aug 31, 2022 · 2 comments

Comments

@reynir
Copy link

reynir commented Aug 31, 2022

The mirage module is named Kv. Perhaps it can be renamed Chamelon_kv so as to make it clear it's a Chamelon KV device. Obviously a breaking change :/

@yomimono
Copy link
Owner

yomimono commented Sep 1, 2022

Possibly it should be wrapped so as to be Chamelon.Kv? That does feel a bit more natural to me. I agree that Kv seems a bit presumptuous.

@reynir
Copy link
Author

reynir commented Sep 1, 2022

Yes, I think that works, too. One "concern" could be if you would want to release the mirage code separately at some point (but then you could as well change the name again).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants