-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support rspack #24
Comments
Hello @singh-jay, thanks for your feedback. I'm not opposed to compatibility with rspack, but it seems complicated to me because there are differences in the API. On investigating, I can already see 2 points that pose a problem:
@alexander-akait (Hi) What do you think? |
We can add check |
Sorry for the delay, this line is important because it marks the svgs for the plugin. If it's not marked, the plugin will ignore the svg and won't work properly. @alexander-akait Do you have contact with the rspack team? Or do you know how we could solve this problem? Thanks |
/cc @hardfist |
thanks,we will see whether we can be compatible with this plugin |
If the feature solves a problem you have, specify it here.
I'm trying to migrate our webpack project to rspack, everything is working except the svg-sprites, as this project is in active development, I hope you will consider support for rspack as well.
Describe the proposed feature.
Getting error -
/node_modules/svg-chunk-webpack-plugin/lib/loader.js:20
this._module.factoryMeta = this._module.factoryMeta || {};
^
TypeError: Cannot read properties of undefined (reading 'factoryMeta')
at Object.SvgChunkWebpackLoader
Describe alternatives you've considered
svg-sprite-loader
Additional context
Minimal example repo - https://github.com/singh-jay/svg-chunk-plugin-test
Importance
Nice to have
The text was updated successfully, but these errors were encountered: