Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Garbage collection for Text and RichText #58

Closed
hackerwins opened this issue Jun 6, 2020 · 2 comments · Fixed by #104
Closed

Garbage collection for Text and RichText #58

hackerwins opened this issue Jun 6, 2020 · 2 comments · Fixed by #104
Assignees
@dc7303
Labels
enhancement 🌟 New feature or request good first issue 🐤 Good for newcomers

Comments

@hackerwins
Copy link
Member

In issue #3, we have implemented Garbage Collection for child elements of Container such as Array and Object.

https://github.com/yorkie-team/yorkie/blob/master/pkg/document/json/root.go#L94

Text and Rich Text use RgaTreeSplit and may have removed TextNodes inside Although they are not Container. We need the Garbage Collection of this removed TextNodes.

https://github.com/yorkie-team/yorkie/blob/master/pkg/document/json/rga_tree_split.go#L225
@hackerwins hackerwins added good first issue 🐤 Good for newcomers enhancement 🌟 New feature or request labels Jun 6, 2020
@dc7303
Copy link
Member

dc7303 commented Sep 20, 2020

Could I try this issue?

@hackerwins
Copy link
Member Author

@dc7303 Sure.

@dc7303 dc7303 mentioned this issue Nov 17, 2020
Merged
@hackerwins hackerwins mentioned this issue Jan 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dc7303 dc7303

Labels
enhancement 🌟 New feature or request good first issue 🐤 Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add garbage collection for text type dc7303/yorkie
2 participants
@hackerwins @dc7303