Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simultaneous translation #24

Closed
3 tasks done
Ilithy opened this issue Oct 8, 2022 · 8 comments
Closed
3 tasks done

Simultaneous translation #24

Ilithy opened this issue Oct 8, 2022 · 8 comments
Labels
enhancement New feature or request

Comments

@Ilithy
Copy link
Contributor

Ilithy commented Oct 8, 2022

Describe your suggested feature

I don't know if this is feasible, but it would be fantastic if, during a translation, Translate You could make the translation request to all these engines at the same time.
Each translation engine would display its result in a separate tab
This would make it possible to check the translations by the different engines very quickly and easily, which would be extremely appreciable (especially if other engines come to join TY).

Thanks a lot

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
@Ilithy Ilithy added the enhancement New feature or request label Oct 8, 2022
@Ilithy Ilithy changed the title simultaneous translation Simultaneous translation Oct 8, 2022
@Ilithy Ilithy changed the title Simultaneous translation Simultaneous translations Oct 8, 2022
@Ilithy Ilithy changed the title Simultaneous translations Simultaneous translation Oct 8, 2022
@Bnyro
Copy link
Member

Bnyro commented Oct 9, 2022

That's not possible with the current way of how Translate You works, but it wouldn't be too hard to implement :)

As always, the thing I struggle with the most is to make it become good-looking UI-wise:

  • How do you imagine the different tabs to be like (where, how to switch between them)?
  • Should the option for it be just a switch in the settings?

Apart from that I see one major issue here:

  • The different engines support different languages, therefore there'll be a need to work around that somehow

What I could also imagine instead is a button, for example next to the translated text, clicking it opens a dialog that allows to choose to fetch the translation from another supported engine, which would be better/easier in terms of UI I think.

Cheers

@Ilithy
Copy link
Contributor Author

Ilithy commented Oct 9, 2022

That's not possible with the current way of how Translate You works, but it wouldn't be too hard to implement :)

That would be really awesome 😍, thank you for considering it 🙏 (even if it doesn't included).

How do you imagine the different tabs to be like (where, how to switch between them)?

I was thinking about small buttons (each engine having its own button, visible if you activate the translation engine in the settings) in the system accent color (like the "+" button) to install
at this place (screenshot), it would switch the view from one translation engine to another (this would be, for me, the most pleasant and convenient, we can easily change the engine, to compare them).

Screenshot_20221009-184235__01

Should the option for it be just a switch in the settings?

Exactly, for each translation engine

The different engines support different languages, therefore there'll be a need to work around that somehow

Indeed, simply displaying a message, "languages not supported by this translation engine, sorry" would not be possible?

What I could also imagine instead is a button, for example next to the translated text, clicking it opens a dialog that allows to choose to fetch the translation from another supported engine, which would be better/easier in terms of UI I think.

In my opinion it would be less convenient, because in my method, we can change engines quickly, and compare the work of different engines, while your method forces (well, I think) to systematically send a request at each change of translation engine.
But I could be totally wrong...

Thank you very much ❤️

@Ilithy
Copy link
Contributor Author

Ilithy commented Oct 9, 2022

For a slightly more precise idea of the design I'm thinking of for the (open tab) buttons mentioned in my previous comment. here is an example very close to my idea:

Screenshot_20221009-205952
(screenshot of the Neo Store app)

But displayed at the bottom, not at the top (more accessible). With exactly the same behavior, when you click on it, it switches to a "new tab" displaying different information (in our case, translations by different engines), if necessary you can drag the buttons (finger slide from right to left, and vice versa on the button line) to display more.
What do you think about this?

@Bnyro
Copy link
Member

Bnyro commented Oct 10, 2022

I decided to set this as the major goal for version 2.0 as it'll require rewriting some core parts of the code and also some work spent on UI stuff that'll probably transform parts of the app revolutionary 😉

Before that I'm gonna have a look at some other translation engines to add so that the feature will be really useful then when it's being rolled out :)

PS: I like the idea with the chip group, we'll just need to figure out how it'll look the best in TY in the end. Apart from that I'll need to find the best way to make it work well with new translation engines too without much additional work for each engine, so there's some work to do obviously 😂

@Ilithy
Copy link
Contributor Author

Ilithy commented Oct 10, 2022

I decided to set this as the major goal for version 2.0 as it'll require rewriting some core parts of the code and also some work spent on UI stuff that'll probably transform parts of the app revolutionary 😉

🥳🙏 Thank you very much, this is going to take a lot of work, thank you for putting it on your to-do list.
Indeed this will make Translate You the most effective translation app on Android by far.
I think it may be necessary to modify other parts, so that it is really practical, like the "+" button which should surely become smaller (maybe).

Before that I'm gonna have a look at some other translation engines to add so that the feature will be really useful then when it's being rolled out :)

It's clever. I just added a request to add Deepl (which is excellent, and has an interesting free version API)
If it doesn't bother you, I'll make other requests for alternative translation engines.

I like the idea with the chip group, we'll just need to figure out how it'll look the best in TY in the end.

I understand, these are preliminary ideas: it could be like in the example, with less padding and a selectable order of appearance

Apart from that I'll need to find the best way to make it work well with new translation engines too without much additional work for each engine, so there's some work to do obviously

yes, I get it, this part of the story is going to be difficult for me ^_*

@Bnyro
Copy link
Member

Bnyro commented Oct 17, 2022

Short update on that:

  1. During the last few updates, as a side effect, I've been pretty much doing all the refactoring and rewriting to make it possible to include this feature in the future.
  2. Now the bad part: as I won't be at home for a week starting this Saturday, I can't promise I'll find time to work on it before as I still have to maintain some other stuff and also do some IRL stuff to before my trip starts :)

So, just wanted to quickly inform you that I didn't forget it yet :)

@Ilithy
Copy link
Contributor Author

Ilithy commented Oct 17, 2022

Thank you very much for this information and the follow-up on this request (but also on the rest), you have already done a lot of work, and TY is already one of the best apps in this category (it may already be the best), thank you for that.

I appreciate you keeping this feature in mind, it's already a lot, thank you.

I hope your trip is going well, take care of yourself

@Bnyro Bnyro closed this as completed in 71916dc Oct 21, 2022
@Ilithy
Copy link
Contributor Author

Ilithy commented Oct 21, 2022

Wow It was really very very fast, infinitely more than I thought, thank you very much 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants