Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getter and setter accessors do not agree in visibility. #8

Closed
killerdbob opened this issue Jan 7, 2022 · 4 comments
Closed

Getter and setter accessors do not agree in visibility. #8

killerdbob opened this issue Jan 7, 2022 · 4 comments

Comments

@killerdbob
Copy link

killerdbob commented Jan 7, 2022

when I use svchat, ndnts show up a declare bug, and I change get state(): L3Face.State; to private get state(): L3Face.State;, bug disappear.

problem:

Error: node_modules/@ndn/l3face/lib/l3face.d.ts:28:9 - error TS2379: Getter and setter accessors do not agree in visibility.

28     get state(): L3Face.State;
           ~~~~~


Error: node_modules/@ndn/l3face/lib/l3face.d.ts:29:17 - error TS2379: Getter and setter accessors do not agree in visibility.

29     private set state(value);
                   ~~~~~
@yoursunny
Copy link
Owner

when I use svchat

What is this?

@killerdbob
Copy link
Author

when I use svchat

What is this?

https://github.com/pulsejet/svchat

@yoursunny
Copy link
Owner

yoursunny commented Jan 13, 2022

SvChat repository is using TypeScript 4.1:
https://github.com/pulsejet/svchat/blob/19b1abe9b9f45be2d94b9d8c6e095d9a1a89bc97/package.json#L51

Having different visibility for getter and setter is introduced in TypeScript 4.3:
microsoft/TypeScript#42425

Looks like @pulsejet needs to upgrade to latest TypeScript.
Please report an issue in their repository, as this is not my bug.

If you are looking for a chat app, see also:
https://github.com/yoursunny/NDNts-chat

@killerdbob
Copy link
Author

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants