Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons for small mobile screens #268

Closed
OVA-robin opened this issue Oct 21, 2020 · 3 comments
Closed

Buttons for small mobile screens #268

OVA-robin opened this issue Oct 21, 2020 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@OVA-robin
Copy link

All our buttons need to change on screens that are smaller than 375 pix.
The font size should be scaled from 20 down to 16
The margin of the pages should be changed from 48 pix to 24
The green background color of the button must be changed from # 1FAB2E to # 1A8924

(Our current button meets the accessibility requirements we follow. Font size 20 on our green button.
But when the font is scaled down, the contrast needs to be increased. Hence a darker button so we still meet the requirements for accessibility.)

@grandorf grandorf added the bug Something isn't working label Nov 6, 2020
@grandorf grandorf self-assigned this Nov 6, 2020
@grandorf
Copy link
Member

grandorf commented Nov 11, 2020

Should we not say small buttons will be on screen sizes under 400px or maybe even use our media queries and say under 576px? The problem with buttons is also for sizes over 375 I would say.

"The margin of the pages should be changed from 48 pix to 24"

What does this mean?

Should the new color of the button only be applied for small screens when we also change the font-size?

@OVA-robin
Copy link
Author

Oh sorry. I ment the margin of the BUTTON should be changed from 48 to 24 on small screens. So the long button text doesn't pop out.

@OVA-robin
Copy link
Author

I have only seen problems with buttons on iPhone 5 and iPhone SE witch have 320 pix with. I don't think we shoud have these new dark buttons on iPhone 6 if it looks ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants