Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Type hinting bug in new 2.0.1 with Python 3.7,3.8 #13

Closed
JonasDev1 opened this issue Feb 3, 2022 · 3 comments
Closed

[BUG] Type hinting bug in new 2.0.1 with Python 3.7,3.8 #13

JonasDev1 opened this issue Feb 3, 2022 · 3 comments

Comments

@JonasDev1
Copy link

JonasDev1 commented Feb 3, 2022

Describe the bug
With the latest update, type hinting features from python 3.9 have been added, which making the application no longer compatible for Python 3.7 and 3.8.

To Reproduce
Steps to reproduce the behavior:

  1. Install 'awscliv2' on < Python3.9
  2. Run the following command
    ``awsv2 --install```

Problem solving
The problem occurs since the refactoring at least in the interactive_process.py. It is related to the typ hinting in method signature with Popen[bytes], which will only beeing supported out of the box since Py3.9.
To solve it in 3.7 and 3.8 you can import from __future__ import annotations (See python/typeshed#4948)

@JonasDev1 JonasDev1 changed the title [BUG] Type hinting bug in new 2.0.1 [BUG] Type hinting bug in new 2.0.1 with Python 3.7,3.8 Feb 3, 2022
@vemel
Copy link
Collaborator

vemel commented Feb 3, 2022

Thank you for the report! Will fix today

@vemel vemel added the bug label Feb 3, 2022
@vemel
Copy link
Collaborator

vemel commented Feb 3, 2022

Fixed and released in 2.0.2. Please let me know if it works as it should.

@JonasDev1
Copy link
Author

Thank you 👍
The cli runs now on Python 3.7 successfully

@vemel vemel closed this as completed Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants