Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing @throws BackoffException phpDoc #13

Closed
webarchitect609 opened this issue Dec 17, 2020 · 0 comments
Closed

Missing @throws BackoffException phpDoc #13

webarchitect609 opened this issue Dec 17, 2020 · 0 comments

Comments

@webarchitect609
Copy link
Contributor

There's no @throws BackoffException for several methods. So Php Storm thinks I'm coding wrong. "Exception BackoffException is never thrown" he told me today.

screenshot of IDE

So I couldn't stand it and make PR #12 with this and a few more fixes. It would be nice if you can review them. The only file I left unchanged is changelog.

P.S.: Regarding failed test @ php 7.3. There's probably some kind of issue with Travis. I have php 7.3 installed locally and tested there. Everything's fine.

coverage is OK at php 7.3

P.P.S: Thanks a lot for this lib! It saved me a lot of time at my work! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants