Abort in win_release_image

[CyberShadow]

Hi and thank you for your continued work on compton. There seem to be some regressions in the latest versions. Here is the first issue.

• Platform - Arch Linux (amd64)
• GPU: Intel Corporation UHD Graphics 620 (rev 07)
• Monitor: T580 4k monitor running at 2880x1620
• Drivers: xf86-video-intel 1:2.99.917+863+g6afed33b-1, mesa 19.0.4-1
• glxinfo -B:

  name of display: :0
  display: :0  screen: 0
  direct rendering: Yes
  Extended renderer info (GLX_MESA_query_renderer):
      Vendor: Intel Open Source Technology Center (0x8086)
      Device: Mesa DRI Intel(R) UHD Graphics 620 (Kabylake GT2)  (0x5917)
      Version: 19.0.4
      Accelerated: yes
      Video memory: 3072MB
      Unified memory: yes
      Preferred profile: core (0x1)
      Max core profile version: 4.5
      Max compat profile version: 3.0
      Max GLES1 profile version: 1.1
      Max GLES[23] profile version: 3.2
  OpenGL vendor string: Intel Open Source Technology Center
  OpenGL renderer string: Mesa DRI Intel(R) UHD Graphics 620 (Kabylake GT2) 
  OpenGL core profile version string: 4.5 (Core Profile) Mesa 19.0.4
  OpenGL core profile shading language version string: 4.50
  OpenGL core profile context flags: (none)
  OpenGL core profile profile mask: core profile
  
  OpenGL version string: 3.0 Mesa 19.0.4
  OpenGL shading language version string: 1.30
  OpenGL context flags: (none)
  
  OpenGL ES profile version string: OpenGL ES 3.2 Mesa 19.0.4
  OpenGL ES profile shading language version string: OpenGL ES GLSL ES 3.20  
  

• Environment: i3-gaps
• Compton version: git next (094f00a)
• compton --diagnostics:

  **Version:** v6-rc1-137-g094f00a
  
  ### Extensions:
  
  * Shape: Yes
  * XRandR: Yes
  * Present: Present
  
  ### Misc:
  
  * Use Overlay: Yes
  * Config file used: /home/vladimir/.config/compton.conf
  
  ### Drivers (inaccurate):
  
  modesetting, �� 
  

• Compton configuration:

  # Thank you code_nomad: http://9m.no/ꪯ鵞
  
  #################################
  #
  # Backend
  #
  #################################
  
  # Backend to use: "xrender" or "glx".
  # GLX backend is typically much faster but depends on a sane driver.
  backend = "glx";
  
  #################################
  #
  # GLX backend
  #
  #################################
  
  glx-no-stencil = true;
  
  # GLX backend: Copy unmodified regions from front buffer instead of redrawing them all.
  # My tests with nvidia-drivers show a 10% decrease in performance when the whole screen is modified,
  # but a 20% increase when only 1/4 is.
  # My tests on nouveau show terrible slowdown.
  # Useful with --glx-swap-method, as well.
  glx-copy-from-front = false;
  
  # GLX backend: Use MESA_copy_sub_buffer to do partial screen update.
  # My tests on nouveau shows a 200% performance boost when only 1/4 of the screen is updated.
  # May break VSync and is not available on some drivers.
  # Overrides --glx-copy-from-front.
  # glx-use-copysubbuffermesa = true;
  
  # GLX backend: Avoid rebinding pixmap on window damage.
  # Probably could improve performance on rapid window content changes, but is known to break things on some drivers (LLVMpipe).
  # Recommended if it works.
  # glx-no-rebind-pixmap = true;
  
  
  # GLX backend: GLX buffer swap method we assume.
  # Could be undefined (0), copy (1), exchange (2), 3-6, or buffer-age (-1).
  # undefined is the slowest and the safest, and the default value.
  # copy is fastest, but may fail on some drivers,
  # 2-6 are gradually slower but safer (6 is still faster than 0).
  # Usually, double buffer means 2, triple buffer means 3.
  # buffer-age means auto-detect using GLX_EXT_buffer_age, supported by some drivers.
  # Useless with --glx-use-copysubbuffermesa.
  # Partially breaks --resize-damage.
  # Defaults to undefined.
  glx-swap-method = "undefined";
  
  #################################
  #
  # Shadows
  #
  #################################
  
  # Enabled client-side shadows on windows.
  shadow = true;
  # Don't draw shadows on DND windows.
  no-dnd-shadow = true;
  # Avoid drawing shadows on dock/panel windows.
  no-dock-shadow = true;
  # Zero the part of the shadow's mask behind the window. Fix some weirdness with ARGB windows.
  clear-shadow = true;
  # The blur radius for shadows. (default 12)
  shadow-radius = 5;
  # The left offset for shadows. (default -15)
  shadow-offset-x = -5;
  # The top offset for shadows. (default -15)
  shadow-offset-y = -5;
  # The translucency for shadows. (default .75)
  shadow-opacity = 0.5;
  
  # Set if you want different colour shadows
  # shadow-red = 0.0;
  # shadow-green = 0.0;
  # shadow-blue = 0.0;
  
  # The shadow exclude options are helpful if you have shadows enabled. Due to the way compton draws its shadows, certain applications will have visual glitches
  # (most applications are fine, only apps that do weird things with xshapes or argb are affected).
  # This list includes all the affected apps I found in my testing. The "! name~=''" part excludes shadows on any "Unknown" windows, this prevents a visual glitch with the XFWM alt tab switcher.
  shadow-exclude = [
      "! name~=''",
      "name = 'Notification'",
      "name = 'Plank'",
      "name = 'Docky'",
      "name = 'Kupfer'",
      "name = 'xfce4-notifyd'",
      "name *= 'VLC'",
      "name *= 'compton'",
      "name *= 'Chromium'",
      "name *= 'Chrome'",
      "class_g = 'Conky'",
      "class_g = 'Kupfer'",
      "class_g = 'Synapse'",
      "class_g ?= 'Notify-osd'",
      "class_g ?= 'Cairo-dock'",
      "class_g ?= 'Xfce4-notifyd'",
      "class_g ?= 'Xfce4-power-manager'",
      "_GTK_FRAME_EXTENTS@:c"
  ];
  # Avoid drawing shadow on all shaped windows (see also: --detect-rounded-corners)
  shadow-ignore-shaped = false;
  
  #################################
  #
  # Opacity
  #
  #################################
  
  opacity-rule = [
    # "50:class_g = 'i3-bar'"
  
    # https://github.com/i3/i3/issues/1848#issuecomment-131814317
    "0:_NET_WM_STATE@:32a *= '_NET_WM_STATE_HIDDEN'"
  ];
  menu-opacity = 1;
  inactive-opacity = 0.9;
  active-opacity = 1;
  frame-opacity = 1;
  inactive-opacity-override = false;
  alpha-step = 0.06;
  
  # Dim inactive windows. (0.0 - 1.0)
  # inactive-dim = 0.2;
  # Do not let dimness adjust based on window opacity.
  # inactive-dim-fixed = true;
  # Blur background of transparent windows. Bad performance with X Render backend. GLX backend is preferred.
  # blur-background = true;
  # Blur background of opaque windows with transparent frames as well.
  # blur-background-frame = true;
  # Do not let blur radius adjust based on window opacity.
  blur-background-fixed = false;
  blur-background-exclude = [
      "window_type = 'dock'",
      "window_type = 'desktop'"
  ];
  
  #################################
  #
  # Fading
  #
  #################################
  
  # Fade windows during opacity changes.
  fading = false;
  # The time between steps in a fade in milliseconds. (default 10).
  fade-delta = 4;
  # Opacity change between steps while fading in. (default 0.028).
  fade-in-step = 0.03;
  # Opacity change between steps while fading out. (default 0.03).
  fade-out-step = 0.03;
  # Fade windows in/out when opening/closing
  # no-fading-openclose = true;
  
  # Specify a list of conditions of windows that should not be faded.
  fade-exclude = [ ];
  
  #################################
  #
  # Other
  #
  #################################
  
  # Try to detect WM windows and mark them as active.
  mark-wmwin-focused = true;
  # Mark all non-WM but override-redirect windows active (e.g. menus).
  mark-ovredir-focused = true;
  # Use EWMH _NET_WM_ACTIVE_WINDOW to determine which window is focused instead of using FocusIn/Out events.
  # Usually more reliable but depends on a EWMH-compliant WM.
  use-ewmh-active-win = true;
  # Detect rounded corners and treat them as rectangular when --shadow-ignore-shaped is on.
  detect-rounded-corners = true;
  
  # Detect _NET_WM_OPACITY on client windows, useful for window managers not passing _NET_WM_OPACITY of client windows to frame windows.
  # This prevents opacity being ignored for some apps.
  # For example without this enabled my xfce4-notifyd is 100% opacity no matter what.
  detect-client-opacity = true;
  
  # Specify refresh rate of the screen.
  # If not specified or 0, compton will try detecting this with X RandR extension.
  refresh-rate = 0;
  
  # Set VSync method. VSync methods currently available:
  # none: No VSync
  # drm: VSync with DRM_IOCTL_WAIT_VBLANK. May only work on some drivers.
  # opengl: Try to VSync with SGI_video_sync OpenGL extension. Only work on some drivers.
  # opengl-oml: Try to VSync with OML_sync_control OpenGL extension. Only work on some drivers.
  # opengl-swc: Try to VSync with SGI_swap_control OpenGL extension. Only work on some drivers. Works only with GLX backend. Known to be most effective on many drivers. Does not actually control paint timing, only buffer swap is affected, so it doesn’t have the effect of --sw-opti unlike other methods. Experimental.
  # opengl-mswc: Try to VSync with MESA_swap_control OpenGL extension. Basically the same as opengl-swc above, except the extension we use.
  # (Note some VSync methods may not be enabled at compile time.)
  vsync = "opengl-swc";
  
  # Enable DBE painting mode, intended to use with VSync to (hopefully) eliminate tearing.
  # Reported to have no effect, though.
  dbe = false;
  # Painting on X Composite overlay window. Recommended.
  paint-on-overlay = true;
  
  # Limit compton to repaint at most once every 1 / refresh_rate second to boost performance.
  # This should not be used with --vsync drm/opengl/opengl-oml as they essentially does --sw-opti's job already,
  # unless you wish to specify a lower refresh rate than the actual value.
  sw-opti = true;
  
  # Unredirect all windows if a full-screen opaque window is detected, to maximize performance for full-screen windows, like games.
  # Known to cause flickering when redirecting/unredirecting windows.
  # paint-on-overlay may make the flickering less obvious.
  unredir-if-possible = true;
  
  # Specify a list of conditions of windows that should always be considered focused.
  focus-exclude = [ ];
  
  # Use WM_TRANSIENT_FOR to group windows, and consider windows in the same group focused at the same time.
  detect-transient = true;
  # Use WM_CLIENT_LEADER to group windows, and consider windows in the same group focused at the same time.
  # WM_TRANSIENT_FOR has higher priority if --detect-transient is enabled, too.
  detect-client-leader = true;
  
  #################################
  #
  # Window type settings
  #
  #################################
  
  wintypes:
  {
      tooltip =
      {
          # fade: Fade the particular type of windows.
          fade = true;
          # shadow: Give those windows shadow
          shadow = false;
          # opacity: Default opacity for the type of windows.
          opacity = 0.85;
          # focus: Whether to always consider windows of this type focused.
          focus = true;
      };
  };
  

Steps of reproduction

1. Start compton
2. Open a new window

Expected behavior

Compton continues working

Current Behavior

Compton crashes

Stack trace

#0  0x00007ffff6eb382f in raise () from /usr/lib/libc.so.6
#1  0x00007ffff6e9e672 in abort () from /usr/lib/libc.so.6
#2  0x00007ffff6e9e548 in __assert_fail_base.cold.0 () from /usr/lib/libc.so.6
#3  0x00007ffff6eabdb6 in __assert_fail () from /usr/lib/libc.so.6
#4  0x000055555556851a in win_release_image (base=0x0, w=0x555555927f90) at ../src/win.c:202
#5  0x0000555555568997 in win_try_rebind_image (ps=0x5555555c7770, w=0x555555927f90) at ../src/win.c:255
#6  0x0000555555563b21 in refresh_stale_images (ps=0x5555555c7770) at ../src/compton.c:1222
#7  0x0000555555563d53 in _draw_callback (loop=0x7ffff7c32720, ps=0x5555555c7770, revents=256) at ../src/compton.c:1262
#8  0x00005555555641cb in delayed_draw_timer_callback (loop=0x7ffff7c32720, w=0x5555555c7800, revents=256) at ../src/compton.c:1354
#9  0x00007ffff7c26993 in ev_invoke_pending () from /usr/lib/libev.so.4
#10 0x00007ffff7c2a2dd in ev_run () from /usr/lib/libev.so.4
#11 0x0000555555566f6b in session_run (ps=0x5555555c7770) at ../src/compton.c:2188
#12 0x000055555556721a in main (argc=1, argv=0x7fffffffe0c8) at ../src/compton.c:2270

Other details

This is a regression - introduced in commit 094f00a (current next).

[yshui]

Is this with --experimental-backends?

[CyberShadow]

Sorry, I forgot to include my compton invocation. It is as follows:

export allow_rgb10_configs=false # https://github.com/chjj/compton/issues/477
exec compton --force-win-blend --glx-fshader-win "$(cat "$COMPTON_SHADER")"

COMPTON_SHADER is https://dump.thecybershadow.net/9c2320fcc641a26dfc0f780c2a62a95a/compton-fake-transparency-fshader-win.glsl .

However, this problem and #177 occurs even without any command-line parameters or unusual environment variables.

[yshui]

Ah, I see where the problem is.

[yshui]

@CyberShadow should be fixed now

[CyberShadow]

Confirmed fixed, thanks.