-
Notifications
You must be signed in to change notification settings - Fork 0
/
ChangeLog.2015
2066 lines (1401 loc) · 70.5 KB
/
ChangeLog.2015
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
2015-12-12 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* ttf: Update bundled freetype to release 2.6.2.
* libxml: Update bundled libxml2 to release 2.9.3.
2015-11-28 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* webp: Updated bundled libwebp to release 0.4.4.
* png: Updated bundled libpng to release 1.6.19.
2015-11-05 Glenn Randers-Pehrson <glennrp@simple.dallas.tx.us>
* coders/png.c (WriteOnePNGImage): Added "volatile" to
several declarations to stop "might be clobbered" warnings.
2015-11-07 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* NEWS.txt: Update NEWS for 1.3.23 release.
2015-11-06 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* magick/command.c (IdentifyImageCommand): Fix problem that
identify with -format "%A" does not always report correct answer
due to insufficient analysis of image. Fixes SourceForge bug #326
"gm identify: transparency detection bug ".
2015-11-05 Glenn Randers-Pehrson <glennrp@simple.dallas.tx.us>
* coders/png.c (WriteOnePNGImage): Restored a "volatile"
declaration that was accidentally deleted on 2015-11-03.
2015-11-04 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* configure.ac: Add checks for 'ps2write' and 'eps2write' as
Ghostscript Postscript and Encapsulated Postscript
writers. Resolves issue reported to graphicsmagick-bugs mailing
list on 2015-11-01 entitled "Failure to detect pswrite and
epswrite Ghostscript devices".
2015-11-03 Glenn Randers-Pehrson <glennrp@simple.dallas.tx.us>
* coders/png.c (ReadRawProfile): Issue a warning instead of
an error when attempting to read a zero-length profile.
2015-11-01 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* magick/studio.h (MagickSleep): Provide the macro 'MagickSleep'
to call a function which delays for one second. No longer provide
a macro 'sleep' in WIN32 compiles. Resolves issue reported to
graphicsmagick-bugs mailing list on 2005-11-01 entitled "MinGW
build error when sleep re#defined as Sleep".
2015-10-30 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* Magick++/demo/demos.tap: Add zoom test cases to test resize to
original dimensions, change height, and change width.
* magick/resize.c (ScaleImage): Fix regression introduced in
1.3.22 release which results in pixel cache not open if the scale
width and height match the original. Patch by Troy Patteson.
Fixes part of SourceForge bug #323 "ScaleImage() issues in
v1.3.22".
(ScaleImage): Fix double free problem when scaled rows equals
original rows. This regression was added in the 1.3.22 release
via changset 080b99bba574. Based on patch by Troy Patteson.
Fixes remaining part SourceForge bug #323 "ScaleImage() issues in
v1.3.22".
2015-10-24 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* www/Magick++/Image.rst (thumbnail): Paragraph heading fix.
Resolves SourceForge issue #321 "find tiny error in
Magick++/Image.html document".
2015-10-06 Glenn Randers-Pehrson <glennrp@simple.dallas.tx.us>
* docs/*.imdoc: Changed synopses in manpages to add "gm "
prefix to commands. Updated synopsis for "convert" to agree
with what's in the "gm" manpage.
2015-10-05 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* configure.ac: Remove CFLAGS and LDFLAGS deduplication code.
Resolves SourceForge bug #320 OS X "universal build failure".
2015-10-04 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* www/index.rst: Updated for 1.3.22 release.
* NEWS.txt: Updated for 1.3.22 release.
2015-09-27 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* NEWS.txt: Brought up to date with changes thus far since last
release.
* magick/blob.c (OpenBlob): Disable fflush() of read-only handle
under Microsoft Windows, which produced a spurious error status,
blocking file reads for Visual Studio 2015 on Windows 2012 server.
Problem was reported and diagnosed by Dirk Lemstra.
2015-09-19 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* tiff: Update bundled libtiff sources to 4.0.6 release.
* magick/module.c (InitializeModuleSearchPath): Fix compilation
problem when UseInstalledMagick is not defined.
2015-09-13 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* coders/xpm.c: Static string/array allocations are now more
const.
* coders/{ps.c, ps2.c, ps3.c}: Static string/array allocations are
now more const.
* coders/palm.c: Palm static arrays should be 'const'.
* coders/meta.c (jpeg_embed): Stop sharing writeable static string
'psheader'.
(tag_spec): The 'tags' static array should be all 'const'.
* coders/jp2.c: Try to reduce the amount of non-const static data.
* coders/dcm.c (dicom_info): Try to make dicom_info array more
'const'.
* coders/dpx.c: Eliminate use of static buffer strings.
* coders/png.c: Make MNG chunk id strings constant rather than
initialized data.
* magick/render.c (DrawAffineImage): Fix problem that sometimes
output rows are skipped when using OpenMP. Problem identification
and patch by Kevin Matzen. Resolves SourceForge issue #316
"-affine sometimes produces output with missing rows".
2015-08-30 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* tests/rwblob.tap: Add specific tests for BMP2 BMP3 subformats.
* tests/rwfile.tap: Add specific tests for BMP2 BMP3 PS2 PS3
subformats.
2015-08-30 Jaroslav Fojtik <JaFojtik@seznam.cz>
* magick/ImageMagick.rc Replace Imagemagick.ico by GraphicsMagick.ico
* magick/Imagemagick.ico is no longer needed and not referenced anywhere.
2015-08-22 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* README.txt: Fix SourceForge bug 314 "README: bad hg clone URL".
* magick/module.c (GetModuleListForDirectory): Fix Coverity 107017
"Copy into fixed size buffer" and 107013 "Overlapping buffer in
memory copy".
(UnloadModule): Fix SourceForge bug 312 "uninitialized variable
"name" in UnloadModule".
* coders/bmp.c (WriteBMPImage): Fix typo in fix on 2015-08-17.
Fixes Coverity 107014 "Test should be assignment".
* magick/module.c (OpenModules): Fix Coverity 107016 "Resource
leak".
(GetModuleListForDirectory): Fix Coverity 107015 "Resource leak".
2015-08-17 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* coders/bmp.c (WriteBMPImage): Fix inverted alpha channel when
writing BGRA8888 format. Problem was reported by 张铎 via the
graphicsmagick-help discussion list on 2015-08-17.
2015-08-10 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* magick/attribute.c (GenerateEXIFAttribute): Verify that entry
pointer is within the metadata buffer in order to avoid buffer
overflow. Resolution and patch by Federico Larumbe.
* magick/profile.c (SetImageProfile): Avoid crash given NULL
profile pointer. Resolution and patch by Federico Larumbe.
2015-08-09 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* magick/attribute.c (GenerateEXIFAttribute): Fix logic problem
while validating EXIF GPS_OFFSET. Problem reported by Federico
Larumbe.
2015-07-27 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* coders/miff.c (ReadMIFFImage): Applied fix
(http://hg.code.sf.net/u/zacmorris/graphicsmagick/rev/edcc4c184b42)
by Zac Morris to detect buffer overrun while reading zip
compressed data.
(ReadMIFFImage): Fixed some memory leaks which were occuring when
an exception was thrown from zip-compressed data reader.
2015-07-26 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* coders/tiff.c (WritePTIFImage): Fix SourceForge issue #269
"Convert creates SubfileType 0x2 instead of 0x1". From looking at
the code, this is a regression since the time support for the page
subfile type was added (probably via changeset 11831
(037eef0f67f2) on 2007-08-17).
2015-07-19 Jaroslav Fojtik <JaFojtik@seznam.cz>
* dcraw/dcraw.c: Fixed bad define WIN32.
2015-07-18 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* NEWS.txt, www/Hg.rst, www/index.rst: Applied English bugs patch
by Amadu Jalloh.
* dcraw/dcraw.c: Add a port replacement for strnlen().
2015-07-14 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* wand/magick_wand.h: The declaration for MagickGetImageGravity()
was missing. Resolves SourceForge bug #308 magick_wand.h misses
declaration of MagickGetImageGravity.
2015-07-12 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* dcraw: Update bundled dcraw to release 9.26.0.
* png: Updated bundled libpng to release 1.6.17.
* lcms: Update bundled lcms2 to release 2.7.
2015-07-11 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* NEWS.txt: Brought up to date with changes thus far since last
release.
* magick/version.h.in (MagickCopyright): Update most recent
copyright year.
* magick/render.c (DrawAffineImage): Fix problem with negative x
offset. Resolves SourceForge issue #306 "gm fails to convert svg
to jpeg if svg has images with negative coordinates".
* magick/pixel_cache.c (ReadCachePixels): Add checks for integer
overflows.
2015-07-07 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* magick/module.c (ModuleAliases): Add a module alias for GRAYA.
2015-07-05 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* magick/montage.c (MontageImages): Fix Coverity 101317 "Resource
leak".
* magick/blob.c: Limit the data size passed to the read/write
calls to the filesystem blocksize and make multiple calls if
required.
* magick/pixel_cache.c: Limit the data size passed to the
read/write, pread/prwite calls and make multiple calls if
required.
2015-07-04 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* magick/blob.c (WriteBlobFile): Properly handle short read. Read
data in units of filesystem block size.
(BlobToFile): Write data in units of filesystem block size.
* patches: Added directory of patches which may be useful when
integrating new versions of 3rd-party programs or libraries into
the VisualMagick build.
* libxml: Re-applied libxml changes which were used in prior
release.
2015-07-03 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* webp: Updated bundled libwebp to release 0.4.3.
* ttf: Update bundled freetype to release 2.6.
* libxml: Update bundled libxml2 to release 2.9.2.
* tiff/VERSION: Update bundled libtiff to release 4.0.4.
* magick/nt_base.h (HAVE_TIFFISCODECCONFIGURED): Enable use of
TIFFIsCODECConfigured in MSVC build.
* coders/tiff.c: I am too lazy to modify VisualMagick configure so
it is possible to include jpeglib.h in tiff.c, so block out this
low-value code just for MSVC builds.
2015-06-28 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* configure.ac, magick/profile.c: Removed support for lcms 1.X.
No one should be using a lesser version than lcms 2.0.
2015-06-23 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* magick/blob.c (DisassociateBlob): Applied patch by Dirk Lemstra
to assure that the image blob is no longer shared with other
images when the image is written. This helps with thread safety.
2015-06-14 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* magick/command.c: Add/fix utility usage messages for -box,
-convolve, -gravity, -linewidth, -list, -mattecolor, -render and
-shave. Resolves SourceForge issue #302 "MogrifyUsage prints
incomplete information ".
2015-06-10 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* coders/tiff.c (WriteTIFFImage): Include JPEG headers to obtain
its BITS_IN_JSAMPLE definition. This is needed so we can know
what JPEG depth libtiff supports.
* www/index.rst: Add mention of GraphicsMagick having zero defects
reported by Coverity.
2015-06-07 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* Magick++/lib/STL.cpp (adaptiveThresholdImage): Add a new
constructor which accepts a 'double' offset value. The previous
version of this constructor is deprecated and subject to removal
in the future. The size of the class is enlarged to store a
'double' and so this is a break in the ABI when this class was
used. Code using this class should be re-compiled.
* Magick++/lib/Image.cpp (adaptiveThreshold): Add a new version of
this method which accepts a 'double' offset value. The previous
version of the method is deprecated and subject to removal in the
future. Problem was reported by Dirk Lemstra.
2015-05-27 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* coders/gray.c (ReadGRAYImage): Based on feedback from Glenn,
return a gray image from the reader, even if a channelized format
specifier is given.
2015-05-26 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* coders/gray.c (ReadGRAYImage): Fix read glitch caused by
incorrect memset(). Added missing break statement to switch.
Added more logging.
(RegisterGRAYImage): Register "gray" formats R, G, B, C, M, Y, K,
O such that they are not triggered by file extension. It is
necessary to apply a magick prefix to the file name (or set image
magick in the API) in order to force using these formats. This
avoids accidents in case the file extension was used for some
other purpose.
2015-05-25 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* coders/gray.c: Added support for "GRAYA" format. Format
specifiers "R", "G", "B", "A", "C", "M", and "Y" may now be used
to save and restore the associated channel using the same raw
format as "GRAY". These format specifiers were already supported
but did not appear to serve any useful function.
2015-05-24 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* configure.ac: Improve handling of libxml2 dependencies. Only
test for and use libwmflite. Full-up libwmf is no longer used.
* configure.ac: Deduplicate CFLAGS and LDFLAGS.
2015-05-23 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* coders/png.c (WriteOnePNGImage): Eliminate a "clobber"
compilation warning.
* coders/jpeg.c (WriteJPEGImage): Eliminate a "clobber"
compilation warning.
* configure.ac: Don't compute libwmf2 and libxml2 linkage path
based on claimed installation prefix. This is hoped to improve
configure reliability on multi-arch type systems.
2015-05-17 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* configure.ac: Use the first -I, -L, and -l arguments produced by
freetype-config and don't produce arguments based on installation
prefix. This is hoped to improve configure reliability on
multi-arch type systems.
2015-05-16 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* magick/tempfile.c (AcquireTemporaryFileDescriptor): P_tmpdir is
not an environment variable. Need to consider Windows environment
variables for Cygwin.
* magick/random.c (InitializeMagickRandomKernel): For Microsoft
Windows, use CryptGenRandom() to salt the built-in random number
generator.
2015-05-13 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* magick/utility.c (MagickRandReentrant): Quiet Coverity 10092
"Calling risky function".
(MagickRandNewSeed): Quiet Coverity 10093 "Calling risky
function".
* coders/tga.c (ReadTGAImage): Quiet Coverity 10201 "Identical
code for different branches".
* coders/pcx.c (ReadPCXImage): Quiet Coverity 10218 "Identical
code for different branches".
2015-05-10 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* magick/utility.c (GetGeometry): Fix handling of area geometries
in the form "5000000@". Resolves SourceForge issue #299 "-resize
with @ and > in geometry specification".
2015-05-09 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* coders/tiff.c (WriteTIFFImage): Disable matte channel for
compression types which don't support it. Resolves SourceForge
bug #297 "GM distorts image using -transform".
(WriteTIFFImage): When type is Optimize, disable matte channel if
image is opaque.
2015-05-09 Jaroslav Fojtik <JaFojtik@seznam.cz>
* webp/src/utils/endian_inl.h: Fixed defect in intrinsic function
byteswap_ulong for Visual Studio less than 2005.
2015-05-08 Jaroslav Fojtik <JaFojtik@seznam.cz>
* VisualMagick/configure/system_page.cpp,
VisualMagick/configure/system_page.h: Suppress reloading .vcproj
when configuration type does not change.
2015-05-08 Jaroslav Fojtik <JaFojtik@seznam.cz>
* VisualMagick/configure/system_page.cpp,
VisualMagick/configure/system_page.h,
VisualMagick/configure/target_page.h: Ability to re-use already
given paths. It is highly frustrating to enter path for different
configurations again and again.
2015-05-07 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* coders/vid.c (ReadVIDImage): Fix use of uninitialized variable
reported by MSVC 2003 (but not GCC, Clang, or Coverity).
2015-05-05 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* coders/miff.c (ReadMIFFImage): Fix possible leak of profiles in
error path.
* coders/mpc.c (ReadMPCImage): Fix memory leak of values
allocation.
(ReadMPCImage): Fix possible leak of profiles in error path. Fixes
Coverity 80697 "Resource leak".
2015-05-04 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* coders/miff.c (ReadMIFFImage): Fix memory leak of values
allocation.
2015-05-03 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* coders/dpx.c (ReadDPXImage): Hopefully quiet Coverity 10305
"Untrusted loop bound".
* coders/tga.c (ReadTGAImage): Hopefully quiet Coverity 53418
"Untrusted loop bound".
* magick/tempfile.c (AcquireTemporaryFileDescriptor): Eliminate
all use of operating system provided temporary file allocation
functions (all apparently flawed in one way or another) and rely
exclusively on our own implementation.
* magick/constitute.c (ConstituteImage): Quiet Coverity 53399
"Logically dead code".
* coders/webp.c (ReadWEBPImage): Quiet Coverity 53400 "Logically dead
code".
* coders/miff.c (WriteRunlengthPacket): More work to quiet
Coverity 10186 and 10214 "Missing break in switch".
2015-05-02 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* magick/tempfile.c (AcquireTemporaryFileDescriptor): Thoroughly
vet temporary file path. Might quiet Coverity 64613 "Use of
untrusted string value".
* wand/magick_compat.c (ParseGeometry): Another try at quieting
Coverity 10248 "Copy into fixed size buffer" and 10078
"Overlapping buffer in memory copy" in this dead code.
* magick/tempfile.c (AcquireTemporaryFileDescriptor): Remove
unneeded, almost certainly never used, and potentially insecure
use of mkstemp(). Will quiet Coverity 10315 "Insecure temporary
file".
2015-04-30 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* configure.ac: Keep Ghostscript gibberish from appearing in
Configure output.
* coders/miff.c (WriteRunlengthPacket): Quiet Coverity 10186 and
10214 "Missing break in switch".
* magick/pixel_cache.c (GetCacheInfo): Quiet Coverity 10208 "Data
race condition".
* magick/blob.c (CloneBlobInfo): Quiet Coverity 10188 "Data race
condition".
(GetBlobInfo): Quiet Coverity 10191 "Data race condition".
* magick/image.c (AllocateImage): Quiet Coverity 10196 "Data race
condition".
(CloneImage): Quiet Coverity 10206 "Data race condition".
* magick/map.c (MagickMapAllocateMap): Quiet Coverity 10192, 10193
and 10228 "Data race condition".
* configure.ac: Use an algorithm to try to discover the best value
for GSCMYKDevice.
* VisualMagick/bin/delegates.mgk: Recipe for 'gs-cmyk' contained a
typo which breaks using '-type ColorSeparation'.
* coders/pwp.c (ReadPWPImage): Fix Coverity CID 64491 "Integer
handling issues".
2015-04-29 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* coders/xcf.c (load_tile_rle): Quiet Coverity 10259 "Untrusted
loop bound".
* coders/sct.c (ReadSCTImage): Quiet Coverity 10285 "Untrusted
loop bound".
* coders/pwp.c (ReadPWPImage): Quiet Coverity 10299 "Untrusted
loop bound".
* coders/pcd.c (ReadPCDImage): Quiet Coverity 10301 "Untrusted
loop bound".
* coders/tga.c (ReadTGAImage): Quiet Coverity 53418 "Untrusted
loop bound".
* wand/magick_compat.c (ParseGeometry): Fix overlap strcpy() in
dead code. Quiets Coverity 10078 "Overlapping buffer in memory
copy" and 10248 "Copy into fixed size buffer".
* magick/segment.c (Classify): Fix Coverity 64317 "Resource leak".
2015-04-28 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* coders/xcf.c (ReadXCFImage): Fix Coverity 64064 "Resource leak".
* coders/txt.c (ReadTXTImage): Fix Coverity 64061 "Resource leak".
* coders/rla.c (ReadRLAImage): Fix Coverity 64063 "Resource leak".
* coders/dib.c (ReadDIBImage): Fix Coverity 64057 Resource leak".
* magick/segment.c (Classify): Fix Coverity 64056 "Resource leak".
* magick/resize.c (SampleImage): Fix Coverity 64053, 64054, and
64062 "Resource leak".
* magick/render.c (TraceStrokePolygon): Fix Coverity 64055, 64059,
and 64060 "Resource leak".
* magick/magick.c (ListModuleMap): Quiet Coverity 64058 "Resource
leak".
2015-04-28 Glenn Randers-Pehrson <glennrp@simple.dallas.tx.us>
* coders/dpx.c: Fix Coverity 10305 "Untrusted loop bound".
* coders/cineon.c: Fix Coverity 10310 "Untrusted loop bound".
2015-04-27 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* magick/memory.c: All use of user-provided allocation functions
is done via MagickFree(), MagickMalloc(), and MagickRealloc().
2015-04-26 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* magick/colormap.c (MagickConstrainColormapIndex): For out of
range condition, specifically return 0 rather than setting index
to zero, and then returning index.
* coders/pcx.c (ReadPCXImage): Fix Coverity 10197 "Negative loop
bound".
* coders/map.c (ReadMAPImage): Allocate pixels after return case
for 'ping' mode.
(ReadMAPImage): Fix problem added in last commit due to multiple
uses of 'packet_size'.
* magick/floats.c (_Gm_convert_fp16_to_fp32)
(_Gm_convert_fp24_to_fp32): Fix Coverity 10094 "Logically dead
code".
* coders/pcx.c (ReadPCXImage): Fix Coverity 10197 "Negative loop
bound".
* coders/wpg.c (UnpackWPG2Raster): Always test for EOF from
ReadBlobByte(). Should fix Coverity 10205 "Negative loop bound".
2015-04-25 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* coders/pcx.c (ReadPCXImage): Add some more integer-overflow
safety to computations. Add some casts.
* coders/meta.c (formatIPTC): Fix Coverity 10221 "Infinite loop".
* magick/attribute.c (GenerateEXIFAttribute): Fix Coverity 10320
"Untrusted array index read" and "Untrusted loop bound".
2015-04-24 Glenn Randers-Pehrson <glennrp@simple.dallas.tx.us>
* coders/gif.c (ReadGIFImage): Attempt to fix Coverity issue
10284 by using "opacity = (header[3] & 0xff)".
2015-04-23 Glenn Randers-Pehrson <glennrp@simple.dallas.tx.us>
* magick/blob.c (ReadBlobMSBLong, ReadBlobLSBLong): Attempt
to fix various "tainted" or "untrusted" variables
by masking off all but the lower 32 bits returned.
2015-04-23 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* coders/xcf.c (ReadXCFImage): Fix Coverity 10216 "Integer
overflowed argument".
* magick/transform.c (FlipImage): Fix Coverity 61461 "Division or
modulo by zero".
* coders/gif.c: Protect against integer overflow in array size
calculations. Used unsigned type for colormap index.
2015-04-22 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* coders/map.c (ReadMAPImage): Maybe quiet Coverity 10326
"Untrusted pointer read".
* magick/utility.c (GlobExpression): See if testing for null
terminating character quiets Coverity 10246 "Untrusted value as
argument".
* magick/transform.c (FlipImage): Possibly quiet case #4 of
Coverity 10311 "Untrusted value as argument".
* magick/utility.c (Base64Encode): Quiet Coverity 10296 and 10272
"Use of untrusted scalar value".
2015-04-22 Glenn Randers-Pehrson <glennrp@simple.dallas.tx.us>
* magick/blob.c (ReadBlobMSBShort, ReadBlobLSBShort): Attempt
to fix various "tainted" or "untrusted" variables, e.g., in
coders/gif.c and coders/sgi.c by masking off all but the lower
16 bits returned.
2015-04-21 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* coders/tim.c (ReadTIMImage): Make TIM reader more robust against
EOF.
* coders/sct.c (ReadSCTImage): Make SCT reader more robust against
EOF.
* coders/pwp.c (ReadPWPImage): Test loop for EOF.
* coders/otb.c (ReadOTBImage): Make error reporting a bit more
robust.
* coders/jnx.c (ExtractTileJPG): Add some EOF checks.
* coders/cut.c (ReadCUTImage): Limit width/height to range of
signed integer.
* tests/rwfile.tap: Add a R/W file test for ART.
* tests/rwblob.tap: Add a R/W blob test for ART.
* coders/art.c (ReadARTImage): Improve error checking.
2015-04-20 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* coders/sun.c (ReadSUNImage): Try to quench Coverity 10280
"Untrusted loop bound".
* coders/mpc.c (ReadMPCImage): Port MIFF header reading fixes.
2015-04-19 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* coders/miff.c (ReadMIFFImage): MIFF reader failed to read some
MIFF headers properly. Fixes SourceForge issue #298 "invalid next
size (normal)/memory corruption".
2015-04-18 Glenn Randers-Pehrson <glennrp@simple.dallas.tx.us>
* coders/png.c (ReadMNGImage): Fix Coverity 55862 "Resource leak"
and quiet Coverity 55825, 55826, and 55827 "Data race condition".
2015-04-18 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* magick/utility.c (GetToken): Fix an overlapping strlcpy() which
caused a crash in pedantic strlcpy() implementations while parsing
a SVG-style URL from text. Several other issues remain.
2015-04-16 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* magick/command.c (ParseUnixCommandLine): Fix Coverity 59256
"Unused value".
2015-04-15 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* magick/display.c (MagickXROIImage): Fix Coverity 10179 "Missing
break in switch".
(MagickXCropImage): Fix Coverity 10211 "Missing break in switch".
* magick/utility.c (Base64Decode): Fix Coverity 10203 "Missing
break in switch".
(Tokenizer): Quench Coverity 10182 "Missing break in switch". Not
believed to be an actual problem.
* magick/command.c (ParseUnixCommandLine): Fix Coverity 10174 and
10178 "Missing break in switch".
(ProcessBatchOptions): Fix Coverity 10180 "Missing break in
switch".
(ParseWindowsCommandLine): Fix Coverity 10220 "Missing break in
switch".
* coders/xwd.c (ReadXWDImage): Fix Coverity 10095 "Division or
modulo by zero". 3rd try.
2015-04-14 Glenn Randers-Pehrson <glennrp@simple.dallas.tx.us>
* coders/png.c (ReadOneJNGImage): Fix Coverity 55829 and 55846
"Resource leak".
2015-04-13 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* magick/quantize.c (GrayscalePseudoClassImage): Fix Coverity
55831 "Resource leak". 2nd try.
* coders/vid.c (ReadVIDImage): Fix Coverity 55868 and 55874
"Resource leak". 2nd try.
2015-04-12 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* coders/psd.c (ReadPSDImage): Fix Coverity 55855 "Resource
leak". 2nd try.
* coders/pict.c (PictPixmapOp): Fix Coverity 55875 and 55883
"Resource leak". 2nd try.
* coders/pcx.c (WritePCXImage): Fix Coverity 55877 "Resource
leak". 2nd try.
* coders/meta.c (format8BIM): Fix Coverity 55842 "Resource
leak". 2nd try.
* coders/mat.c (WriteMATLABImage): Fix Coverity 55850 "Resource
leak". 2nd try.
* coders/dpx.c (ReadDPXImage): Fix Coverity 55878 "Resource leak".
2nd try.
* coders/preview.c (WritePreviewImage): Fix Coverity 55988
"Resource leak".
2015-04-12 Glenn Randers-Pehrson <glennrp@simple.dallas.tx.us>
* coders/png.c (ReadOneJNGImage): Avoid some memory leaks
newly reported by Coverity (work in progress)
2015-04-12 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* magick/resize.c (ScaleImage): Fix Coverity 55824 "Division or
modulo by float zero".
* magick/annotate.c (AnnotateImage): Fix Coverity 55863
"Uninitialized scalar variable".
* wand/magick_wand.c (MagickDrawImage): Fix Coverity 55828
"Resource leak".
(MagickMontageImage): Fix Coverity 55835 "Resource leak".
* wand/drawing_wand.c (DrawComposite): Fix Coverity 55849
"Resource leak".
* magick/widget.c (MagickXColorBrowserWidget): Fix Coverity 55854
"Resource leak".
* magick/resize.c (ScaleImage): Fix Coverity 55841, 55853, 55858,
and 55860 "Resource leak".
* magick/render.c (ConvertPathToPolygon): Fix Coverity 55836
"Resource leak".
(DrawDashPolygon): Fix Coverity 55837 "Resource leak".
* magick/quantize.c (GrayscalePseudoClassImage): Fix Coverity
55831 "Resource leak".
* magick/paint.c (ColorFloodfillImage): Fix Coverity 55886
"Resource leak".
* magick/map.c (MagickMapAddEntry): Possibly silence 55844
"Resource leak".
* magick/image.c (CloneImage): Fix Coverity 55833 "Resource leak".
* magick/effect.c (BlurImage): Fix Coverity 55851 "Resource leak".
* magick/display.c (MagickXAnnotateEditImage): Fix Coverity 55830
"Resource leak".
(MagickXVisualDirectoryImage): Fix Coverity 55894 "Resource leak".
* magick/constitute.c (ReadImages): Fix Coverity 55834 "Resource
leak".
(ReadInlineImage): Fix Coverity 55843 "Resource leak".
* magick/compress.c (HuffmanEncode2Image): Fix Coverity 55839
"Resource leak".
(HuffmanDecodeImage): Fix Coverity 55859 "Resource leak".
* magick/color.c (GetColorHistogram): Fix Coverity 55845 "Resource
leak".
(ComputeCubeInfo): Fix Coverity 55857 "Resource leak".
* coders/yuv.c (ReadYUVImage): Fix Coverity 55890 "Resource leak".
* coders/wpg.c (UnpackWPG2Raster): Fix Coverity 55832 and 55848
"Resource leak".
2015-04-11 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* coders/vid.c (ReadVIDImage): Fix Coverity 55868 "Resource leak"
(ReadVIDImage): Fix Coverity 55874 "Resource leak".
* coders/txt.c (ReadTXTImage): Fix Coverity 55866 "Resource leak".
* coders/topol.c (ReadTOPOLImage): Fix Coverity 55865 "Resource
leak".
* coders/sgi.c (WriteSGIImage): Fix Coverity 55891 "Resource leak".
* coders/psd.c (ReadPSDImage): Fix Coverity 55855 "Resource leak".
* coders/pict.c (WritePICTImage): Fix Coverity 55867, 55875, 55883
"Resource leak". Fix Coverity 55892 "Resource leak".
* coders/pdb.c (ReadPDBImage): Fix Coverity 55840, 55856, and
55885 "Resource leak".
* coders/pcx.c (WritePCXImage): Fix Coverity 55877 "Resource
leak".
* coders/mvg.c (ReadMVGImage): Fix Coverity 55873 "Resource leak".
* coders/mpeg.c (WriteMPEGImage): Fix Coverity 55880 "Resource
leak".
* coders/miff.c (WriteMIFFImage): Fix Coverity 55864 "Resource
leak".
(WriteMIFFImage): Fix Coverity 55872 "Resource leak".
* coders/meta.c (formatIPTCfromBuffer): Fix Coverity 55838
"Resource leak".
(format8BIM): Fix Coverity 55842 and 55852 "Resource leak".
(formatIPTC): Fix Coverity 5882 "Resource leak".
* coders/mat.c (ReadMATImage): Fix Coverity 55850 "Resource leak".
* coders/map.c (ReadMAPImage): Fix Coverity 55876 "Resource leak".
* coders/logo.c (ReadLOGOImage): Fix Coverity 55870 "Resource
leak".
* coders/label.c (ReadLABELImage): Fix Coverity 55869 "Resource
leak".
* coders/icon.c (ReadIconImage): Fix Coverity 55887 "Resource
leak".
* coders/fits.c (WriteFITSImage): Fix Coverity 55884 "Resource
leak".
* coders/dpx.c (WriteDPXImage): Fix Coverity 55861 "Resource
leak".
(ReadDPXImage): Fix Coverity 55878 "Resource leak".
(ReadDPXImage): Fix Coverity 55879 "Resource leak".
* coders/dib.c (WriteDIBImage): Fix Coverity 55881 "Resource
leak".
(WriteDIBImage): Fix Coverity 55895 "Resource leak".
* coders/cut.c (ReadCUTImage): Fix Coverity 55893 "Resource leak".
* coders/caption.c (ReadCAPTIONImage): Fix Coverity 55888
"Resource leak".
(ReadCAPTIONImage): Fix Coverity 55889 "Resource leak".
(ReadCAPTIONImage): Fix Coverity 55896 "Resource leak".
* magick/annotate.c (RenderX11): Silence Coverity 10106 "Logically
dead code".
* coders/xcf.c: Silence Coverity 10224, 10233, and 10236 "Improper
use of negative value".
* coders/mat.c (ReadMATImage): Silence Coverity 10175 "Improper
use of negative value"
* coders/tga.c (ReadTGAImage): Silence Coverity 10088 "Operands
don't affect result".
* magick/annotate.c (RenderFreetype): Silence Coverity 14396 and
44755 "Unused value".
* coders/wpg.c (LoadWPG2Flags): Silence Coverity 10273 and 10253
"Unused value".
* magick/montage.c (MontageImages): Silence Coverity 10255 "Unused
value".
(MontageImages): Silence Coverity 10264 "Unused value".
2015-04-09 Glenn Randers-Pehrson <glennrp@simple.dallas.tx.us>
* coders/png.c (ReadOneJNGImage): Avoid using a NULL alpha_image
or color_image. (ReadJNGImage): Removed an extraneous CloseBlob().
2015-04-08 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* magick/utility.c (MagickCreateDirectoryPath): Silence Coverity
10098 "Logically dead code".
* magick/resource.c (InitializeMagickResources): Silence Coverity
10101 "Logically dead code".
* magick/magick.c (MagickSignalHandlerMessage): Fix Coverity 44725
"Logically dead code".
* magick/log.c (DestroyLogInfo): Silence Coverity 53659 and 53661
"Data race condition".
(ReadLogConfigureFile): Silence Coverity 53660 "Data race
condition".
* magick/effect.c (DespeckleImage): Fix error handling issue
caused by shadowed variable. Fixes Coverity 10099 "Logically dead
code".
* magick/command.c (TimeImageCommand): Fix Coverity 10097
"Logically dead code".
* magick/attribute.c (ReadMSBLong): Hopefully silence Coverity
10276 "Unintended sign extension".
* coders/sgi.c (ReadSGIImage, WriteSGIImage): Fix Coverity 10243,
10244, 10247, 10254, and 10294 "Unintended sign extension".
2015-04-07 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* magick/xwindow.c (MagickXMakeImage): Quiet Coverity 10282
"Unused value".
2015-04-06 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* coders/tiff.c (WriteTIFFImage): Another change targeting
Coverity 44742 and 44746 "Unintended sign extension".
2015-04-05 Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
* magick/render.c (TracePath): Fix Coverity 10258 "Uninitialized
scalar variable".
* magick/widget.c (MagickXFontBrowserWidget): Fix Coverity 10323
"Sizeof not portable". 2nd try.
* coders/xwd.c (ReadXWDImage): Fix Coverity 10095, 10100, 10104
"Division or modulo by zero". 2nd try.
* magick/analyze.c (GetImageCharacteristics): Fix Coverity 10096
"Logically dead code".
* coders/yuv.c (ReadYUVImage): Fix Coverity 10260 "Structurally
dead code".
* coders/xcf.c (ReadXCFImage): Fix Coverity 10226 "Missing break
in switch".
* coders/tim.c (ReadTIMImage): Fix Coverity 10249 "Unused value".
* coders/tiff.c (CompressionSupported): Fix Coverity 44723
"Logically dead code".
(WriteTIFFImage): Fix Coverity 44742 and 44746 "Unintended sign
extension".
* coders/ps3.c (WritePS3Image): Validate results from TellBlob()