Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify managing the features in the crate #67

Closed
gabhijit opened this issue Apr 4, 2024 · 2 comments
Closed

simplify managing the features in the crate #67

gabhijit opened this issue Apr 4, 2024 · 2 comments

Comments

@gabhijit
Copy link
Collaborator

gabhijit commented Apr 4, 2024

Currently the crate supports three features python-bindings, logging and (soon) wasm. Some of these features are mutually incompatible and hence mutually exclusive as well. Handling these features has resulted in code with a large number of #[cfg(...)] types statement.

This can be perhaps simplified, or the feature level code is kept limited to a couple of files and some simple intuitive macros.

@gabhijit
Copy link
Collaborator Author

A lot of cleanup was performed by #71 .

@gabhijit
Copy link
Collaborator Author

Further fixes by #72 . Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant