-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AENetworks] Update extractor for the current site(s) #26795
Conversation
Works for shows but not specials like: https://play.aetv.com/specials/voices-magnified-locked-up-in-america/full-special These get the following errors: [debug] System config: [] |
Hmm yeah specials are weird. They don't have the video ID in the normal spot and the only place I can find it on the page is within a giant JSON blob. Unfortunately it's mixed in with others. I'll need to dig into the JSON a bit and compare a few samples to see if I can find a reliable way to find the correct one. |
If specials are too difficult then might as well go forward with this PR since it fixes most of the problem. |
@kevinoconnor7 Does the GraphQL server provide different playlists? There's an issue with ads getting injected: #26047 |
@rredford6 Not that I'm aware, though I'm honestly not super familiar with the entire The Platform flow. When I wrote this PR I mostly tried to extract the data that had previously been used (i.e. getting the public The Platform URL). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Nice work. Was able to successfully download an episode
This gets the AENetworks extractor back into a working state. The highlights are: * Support for the `play` subdomain that the content is now hosted on * Extract ThePlatform URLs from the GraphQL endpoint they now use * Properly extract video information from the updates made to the non-play subdomain sites. * Properly extract the series name, season number, and episode numbers * Added more explicit error messages for when extraction fails Fixes ytdl-org#23363
3bf38e4
to
0ee0e1a
Compare
- Fix Fastly format extraction - Add support for play and watch subdomains - Extract series metadata closes ytdl-org#23363 closes ytdl-org#23390 closes ytdl-org#26795 closes ytdl-org#26985
Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
This gets the AENetworks extractor back into a working state. The highlights are:
play
subdomain that the content is now hosted onFixes #23363