Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed manifest v11 resource types #68

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

OnkarVO7
Copy link
Contributor

@OnkarVO7 OnkarVO7 commented Dec 22, 2023

Fixes #67

@OnkarVO7
Copy link
Contributor Author

@yu-iskw could you please review the PR and lets me know if anything else is required. Thanks

@harshach
Copy link

harshach commented Jan 3, 2024

@yu-iskw appreciate your review here. Our users are running into this bug. Thanks

@yu-iskw yu-iskw merged commit 7bee9a6 into yu-iskw:main Jan 4, 2024
5 checks passed
@yu-iskw
Copy link
Owner

yu-iskw commented Jan 4, 2024

@OnkarVO7 Thank you for the pull request. I have merged and published at v0.5.1. Can make sure if it works in your situation?

https://github.com/yu-iskw/dbt-artifacts-parser/releases/tag/v0.5.1

BTW, I am doubbting the issue is caused by datamodel-code-generator with which we generate the pydantic classess from JSON schemas of dbt artifacts. So, we can fix it on the module side, not dbt-core. I will look into it later.

koxudaxi/datamodel-code-generator#1787

@OnkarVO7
Copy link
Contributor Author

OnkarVO7 commented Jan 4, 2024

Thanks @yu-iskw . Tested the new release it is working now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resource_type not defined correctly for manifest v11
3 participants