Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using PropTypes via the main React package is deprecated #38

Open
noahpresler opened this issue May 27, 2017 · 3 comments
Open

Using PropTypes via the main React package is deprecated #38

noahpresler opened this issue May 27, 2017 · 3 comments

Comments

@noahpresler
Copy link

noahpresler commented May 27, 2017 •
edited
Loading

modalFactory propTypes directly accesses the PropTypes via the React Package rather than using the npm prop-types package causing console errors. Accessing them directly is now deprecated.
@jerairrest
Copy link

This is fixed on: https://github.com/jerairrest/boron I do believe

@RodrigoCarvalhoCode
Copy link

Any updates on this?

@Maxim-Mazurok
Copy link

You can check out my fork with the use of prop-types package: https://github.com/Maxim-Mazurok/boron
Also, I've created the pull request: #49 and will be glad for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jerairrest @RodrigoCarvalhoCode @Maxim-Mazurok @noahpresler