Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docdb] Make TS heartbeat metric reporting to master optional #4345

Open
bmatican opened this issue Apr 30, 2020 · 0 comments
Open

[docdb] Make TS heartbeat metric reporting to master optional #4345

bmatican opened this issue Apr 30, 2020 · 0 comments
Assignees
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@bmatican
Copy link
Contributor

bmatican commented Apr 30, 2020

Jira Link: DB-2507
The TS currently reports some rocksdb and raft metadata to the master. This should be optional and should not block the server, else we risk jamming the TS. We likely want to have some timed waits on the operations that require rocksdb & raft locks.

We've seen this lead to deadlocks even, for example for restoring data from an encrypted universe:

  • the restore blocks rocksdb
  • the heartbeater thread calls into rocksdb for stats, so it gets blocked
  • the way keys flow back from the master to the TS is as responses to heartbeats

See #4344

@bmatican bmatican added the area/docdb YugabyteDB core features label Apr 30, 2020
@bmatican bmatican self-assigned this Apr 30, 2020
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels Jun 9, 2022
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature and removed kind/bug This issue is a bug labels Jul 30, 2022
@rthallamko3 rthallamko3 assigned lingamsandeep and unassigned bmatican Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
None yet
Development

No branches or pull requests

3 participants