Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix deprecated returnValue warning in chrome #1460

Merged
merged 1 commit into from
Dec 4, 2013
Merged

fix deprecated returnValue warning in chrome #1460

merged 1 commit into from
Dec 4, 2013

Conversation

zhiyelee
Copy link
Contributor

@zhiyelee zhiyelee commented Dec 4, 2013

As @hatched reported in #1417

chrome now issues a console warning
event.returnValue is deprecated. Please use the standard event.preventDefault() instead.

More discussion, see #1429

@zhiyelee zhiyelee mentioned this pull request Dec 4, 2013
Closed
@lsmith
Copy link
Contributor

lsmith commented Dec 4, 2013

👍

@ezequiel ezequiel merged commit 29a9ed8 into yui:dev-master Dec 4, 2013
@ezequiel
Copy link
Contributor

ezequiel commented Dec 4, 2013

Thanks.

@ezequiel ezequiel mentioned this pull request Dec 4, 2013
Closed
@zhiyelee zhiyelee deleted the fix-returnValue2 branch December 5, 2013 06:10
@zhiyelee
Copy link
Contributor Author

@ezequiel @lsmith should we update the HISTORY.md to refer this fix?

@lsmith
Copy link
Contributor

lsmith commented Dec 10, 2013

@zhiyelee Yep!

zhiyelee added a commit to zhiyelee/yui3 that referenced this pull request Dec 13, 2013
@zhiyelee
update event HISTORY.md to refer yui#1460
f68010a
@zhiyelee zhiyelee mentioned this pull request Dec 13, 2013
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhiyelee @lsmith @ezequiel