-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dd-ddm] : Fix #1492 regression "Drop Based Coding" #1573
Conversation
At ~ 3.7.3 a regression was introduced by 1a55a78 that broke "Drop Based Coding" by using Array.each() for otherDrops which is an Object Literal.
Thanks for your patch. I prefer using Also, I think it need to change ddm-drop.js#L250-254 to Y.Array.each(drops, function(v) {
if (v !== biggest) {
out.push(v);
}
}, this); |
Yes, thanks! I hope the thing will never ever be an array. To be quite frank I haven't understood why it is an object anyway. Whatev, please make it work. I think it would be nice if |
|
Include @okuryu's suggestions. Thanks!
Thanks @okuryu, I wasn't aware of that. I added commits to the PR which include your suggestions. HTH & greetings from Munich! |
@hacklschorsch Thanks! Are you signed our CLA already? |
Just now e-Signed it. Thanks! |
Looks good to me. Current status is waiting any feedbacks by other Committers and Reviewers. I'll merge this after 72 hours or when get explicit approval by a Reviewer. |
Mercí <3 |
I've merged this into |
Fixes #1492 (#1492)
At ~ 3.7.3 a regression was introduced by 1a55a78 that broke
"Drop Based Coding" by using Array.each() for otherDrops which
is an Object Literal.