Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dual Listener and e.preventDefault() support to event-tap #682

Closed
tilomitra opened this issue Apr 30, 2013 · 4 comments
Closed

Add Dual Listener and e.preventDefault() support to event-tap #682

tilomitra opened this issue Apr 30, 2013 · 4 comments

Comments

@tilomitra
Copy link
Contributor

This issue references Trac #2532915. I have tested this fiddle on Android 4.0.3 and it seems to work for me. Waiting to hear back from @mschipperheyn.

Nonetheless, I am trying to make significant improvements to event-tap, to bring it up to par with some of the other fastclick implementations out there.

This ticket will specifically reference making sure event-tap works as expected across the board (but especially in Android 4.0.x (in both, Chrome and the default Android browser)).

@ghost ghost assigned tilomitra Apr 30, 2013
@tilomitra
Copy link
Contributor Author

Current Status:

I would like to group this fix along with the dual-listener work, because they are related. I have a dual-listener branch on my yui3 fork. Currently, the default Android browser fires touch and mouse events, and tap callback gets fired twice. Chrome on Android only fires touch events. Looking into fixing this by having event-tap detaching mouse event handles if the touch event callbacks are fired.

@tilomitra
Copy link
Contributor Author

I'm going to pull in #631 as part of this. Touchmove and touchend events are messed up in Android 4.0.x.

If touchmove event is fired, touchend will not be fired. So once you move your finger, one touchmove is called and then it dies until next touchstart.

https://code.google.com/p/android/issues/detail?id=19827#c12

I still haven't found a valid workaround around this, but it doesn't really impact event-tap. It does impact event-gestures.

@tilomitra
Copy link
Contributor Author

I have a fix for this in my dual-listener branch.

@tilomitra
Copy link
Contributor Author

This is done, since we merged #986.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant