Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bold text within a table isn't bold #104

Closed
2 of 4 tasks
alexanderadam opened this issue Mar 1, 2020 · 1 comment
Closed
2 of 4 tasks

Bold text within a table isn't bold #104

alexanderadam opened this issue Mar 1, 2020 · 1 comment

Comments

@alexanderadam
Copy link

  • goldmark is fully compliant with the CommonMark. Before submitting issue, you must read CommonMark spec and confirm your output is different from CommonMark online demo.
    • Extensions(Autolink without < >, Table, etc) are not part of CommonMark spec. You should confirm your output is different from other official renderers correspond with an extension.
  • goldmark is not dedicated for Hugo. If you are Hugo user and your issue was raised by your experience in Hugo, you should consider create issue at Hugo repository at first .
  • Before you make a feature request, you should consider implement the new feature as an extension by yourself . To keep goldmark itself simple, most new features should be implemented as an extension.

Please answer the following before submitting your issue:

  1. What version of goldmark are you using? : v1.1.23
  2. What version of Go are you using? : 1.13
  3. What operating system and processor architecture are you using? : linux-x64 but it doesn't matter
  4. What did you do? : have bold text within a table structure
  5. What did you expect to see? : that the text is bold
  6. What did you see instead? : it's not bold
  7. Did you confirm your output is different from CommonMark online demo or other official renderer correspond with an extension?: commonmark renders it as bold text
  8. (Feature request only): Why you can not implement it as an extension?:
    • You should avoid saying like "I'm not familiar with this project" "I'm not a Go programmer" as far as possible. This is an open source project and a library for Go programmers. I encourage you to strive to read source codes.
    • I absolutely welcome questions that are difficult even if you read the source codes.

This issue came up because gitea uses goldmark and there's this rendering bug.

This code:

|Bold text below|
|:---:|
|**[this should be bold]()**|

should render like

Bold text below
this should be bold

github on the left and gitea on the right
Screenshot_20200228_231225

@yuin yuin closed this as completed in 2143794 Mar 1, 2020
@alexanderadam
Copy link
Author

alexanderadam commented Mar 1, 2020

Awesome, you are incredibly fast! Thank you for the fix and your work in general! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant