Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor error in htmlBlockType7Regexp #228

Closed
maxb opened this issue Jun 25, 2021 · 2 comments
Closed

Minor error in htmlBlockType7Regexp #228

maxb opened this issue Jun 25, 2021 · 2 comments
Labels

Comments

@maxb
Copy link

maxb commented Jun 25, 2021

In https://github.com/yuin/goldmark/blob/master/parser/html_block.go:

var htmlBlockType7Regexp = regexp.MustCompile(`^[ ]{0,3}<(/)?([a-zA-Z0-9\-]+)(` + attributePattern + `*)(:?>|/>)\s*\n?$`)

Near the end, (:?>|/>) looks like a typo for (?:>|/>) (which could be more simply expressed as /?>)

@stale
Copy link

stale bot commented Jul 26, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 26, 2021
@maxb
Copy link
Author

maxb commented Jul 31, 2021

Not stale, still needs fixing

@stale stale bot closed this as completed Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant