Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goldmark can't emphasized the specific Chinese character #61

Closed
chenzhiwei opened this issue Dec 9, 2019 · 4 comments
Closed

goldmark can't emphasized the specific Chinese character #61

chenzhiwei opened this issue Dec 9, 2019 · 4 comments

Comments

@chenzhiwei
Copy link

After using goldmard process the markdown text **「刻舟求剑」**, the result is still **「刻舟求剑」**, but the expected is 「刻舟求剑」.

  1. What version of goldmark are you using? : v1.1.11
  2. What version of Go are you using? : 1.12
  3. What operating system and processor architecture are you using? : Hugo v0.60.1 on macOS
  4. What did you do? : Create a markdown file with **
  5. What did you expect to see? : The words should be emphasized
  6. What did you see instead? : The words was not emphasized
  7. (Feature request only): Why you can not implement it as an extension?: not applicable
@yuin
Copy link
Owner

yuin commented Dec 9, 2019

This is known CommonMark spec.(see here etc).

CommonMark spec are created by westerners, So they did not take account into our languages(I'm Japanese).

I plan to make goldmark better in CJK even though it breaks CommonMark compliance.

@yuin yuin closed this as completed Dec 9, 2019
@chenzhiwei
Copy link
Author

The GitHub issue editor can handle CJK properly, so maybe it is not CommonMark complaint?

Need to make goldmark as a super set of CommonMark to better support CJK.

@yuin
Copy link
Owner

yuin commented Dec 9, 2019

CommnonMark emphasis rule is complicated as hell, it probably contains ambiguity case.

At least, text like '今日は**「晴れ」**です' is not emphasized on Github issue editor.

@chenzhiwei
Copy link
Author

@yuin OK, you win.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants