Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Use Symbol.dispose to replace our own Disposable #640

Open
1 task done
yume-chan opened this issue May 4, 2024 · 0 comments
Open
1 task done

[Suggestion] Use Symbol.dispose to replace our own Disposable #640

yume-chan opened this issue May 4, 2024 · 0 comments
Labels
type:enhancement New feature or request
Milestone

Comments

@yume-chan
Copy link
Owner

Pre-issue checklist

  • I've searched the issue list but couldn't find the feature I want

How can Tango be improved?

The Explicit resource management proposal adds primitives for disposable pattern.

However, using it requires a polyfill as browser support is not good now.

Symbol.dispose and Symbol.asyncDispose can be easily polyfilled, but not for DisposableStack. I also don't like https://github.com/es-shims/DisposableStack, I don't need a ES3 compatible polyfill with millions of dependencies.

How should the API change?

Add our own polyfills, and refactor disposables to use those primitives.

(Optional) Other information

No response

@yume-chan yume-chan added the type:enhancement New feature or request label May 4, 2024
@yume-chan yume-chan added this to the Backlog milestone May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant