Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loginメソッドを廃止して別のものにする #132

Closed
yupix opened this issue Feb 24, 2024 — with Huly for GitHub · 2 comments
Closed

loginメソッドを廃止して別のものにする #132

yupix opened this issue Feb 24, 2024 — with Huly for GitHub · 2 comments
Assignees
@yupix
Labels
kind/Feature✨ This adds/improves/enhances a feature

Comments

@yupix Huly for GitHub
Copy link
Owner

yupix commented Feb 24, 2024 •
edited
Loading

Summary

loginっぽいことをしてないのにloginというメソッドなのはなんか微妙
@yupix yupix added the kind/Feature✨ This adds/improves/enhances a feature label Feb 24, 2024
@yupix yupix self-assigned this Feb 24, 2024
@yupix
Copy link
Owner Author

yupix commented Mar 1, 2024

代わりを容易する必要もないかもしれない、普通にsessionは別のメソッドで内部で呼び出すようにしてしまった方がよさそう

@yupix
Copy link
Owner Author

yupix commented Mar 1, 2024

互換性の為にloginはユーザーの情報を返すだけのメソッドにしちゃえばよさそう。0.6のうちにそうして0.7ぐらいで消す

@yupix yupix closed this as completed in 8e3ef19 Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yupix yupix

Labels
kind/Feature✨ This adds/improves/enhances a feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yupix