Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Emit 'offline' in not localhost #32

Merged
merged 2 commits into from
Mar 3, 2020
Merged

fix: Emit 'offline' in not localhost #32

merged 2 commits into from
Mar 3, 2020

Conversation

davidyuk
Copy link
Contributor

@davidyuk davidyuk commented May 3, 2019

I'm proposing to extract error handler to get consistent behavior (calling offline hook) on localhost and not on localhost.

@davidyuk
fix: Emit 'offline' in not localhost
60cf44a 
I'm proposing to extract error handler to get consistent behavior (calling `offline` hook) on localhost and not on localhost.
haoqunjiang
haoqunjiang reviewed May 28, 2019
View reviewed changes
Copy link
Collaborator

@haoqunjiang haoqunjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change (error callback not triggered when offline).
What about emitting both events?

@haoqunjiang haoqunjiang merged commit c94341e into yyx990803:master Mar 3, 2020
This was referenced Apr 1, 2020
Merged
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request May 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haoqunjiang haoqunjiang haoqunjiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidyuk @haoqunjiang