fix: add gitlab.SystemHookEvents to support Gitlab system events (arg…

…oproj#12547)

* fix: add gitlab.SystemHookEvents to support Gitlab system events

Closes [ISSUE argoproj#9625]

Signed-off-by: Kamuri Amorim <myk.gata14@gmail.com>

* tests(gitlab.SystemHookEvents): fix tests for gitlab.SystemHookEvents

Signed-off-by: Kamuri Amorim <myk.gata14@gmail.com>

---------

Signed-off-by: Kamuri Amorim <myk.gata14@gmail.com>
Co-authored-by: pasha-codefresh <pavel@codefresh.io>

util/webhook/webhook.go

@@ -441,7 +441,7 @@ func (a *ArgoCDWebhookHandler) Handler(w http.ResponseWriter, r *http.Request) {
 			log.WithField(common.SecurityField, common.SecurityHigh).Infof("GitHub webhook HMAC verification failed")
 		}
 	case r.Header.Get("X-Gitlab-Event") != "":
-		payload, err = a.gitlab.Parse(r, gitlab.PushEvents, gitlab.TagEvents)
+		payload, err = a.gitlab.Parse(r, gitlab.PushEvents, gitlab.TagEvents, gitlab.SystemHookEvents)
 		if errors.Is(err, gitlab.ErrGitLabTokenVerificationFailed) {
 			log.WithField(common.SecurityField, common.SecurityHigh).Infof("GitLab webhook token verification failed")
 		}

util/webhook/webhook_test.go

@@ -336,6 +336,22 @@ func TestGitLabPushEvent(t *testing.T) {
 	hook.Reset()
 }
 
+func TestGitLabSystemEvent(t *testing.T) {
+	hook := test.NewGlobal()
+	h := NewMockHandler(nil, []string{})
+	req := httptest.NewRequest(http.MethodPost, "/api/webhook", nil)
+	req.Header.Set("X-Gitlab-Event", "System Hook")
+	eventJSON, err := os.ReadFile("testdata/gitlab-event.json")
+	assert.NoError(t, err)
+	req.Body = io.NopCloser(bytes.NewReader(eventJSON))
+	w := httptest.NewRecorder()
+	h.Handler(w, req)
+	assert.Equal(t, w.Code, http.StatusOK)
+	expectedLogResult := "Received push event repo: https://gitlab/group/name, revision: master, touchedHead: true"
+	assert.Equal(t, expectedLogResult, hook.LastEntry().Message)
+	hook.Reset()
+}
+
 func TestInvalidMethod(t *testing.T) {
 	hook := test.NewGlobal()
 	h := NewMockHandler(nil, []string{})