Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic insertion of bullet points is unreliable #715

Closed
dschuessler opened this issue Jun 2, 2020 · 6 comments
Closed

Automatic insertion of bullet points is unreliable #715

dschuessler opened this issue Jun 2, 2020 · 6 comments
Labels
Area: Input Related to editor input processing (key presses, key bindings). Area: List editing List editing: continuation, numbering, toggling, etc. Issue: Performance The ability to respond to user actions quickly. Diagnosis requires expertise and detailed info. Res: External Outside of our control/codebase. Upstream Pertaining to an upstream component, or blocked by an upstream issue.

Comments

@dschuessler
Copy link

dschuessler commented Jun 2, 2020

What is the problem?

Insertions of bullet sometimes happens:

  • after indenting with Tab so that the bullet point does not move along with the cursor
  • or not at all

How can I reproduce it?

With a bit of patience and good timing as shown in this GIF. If you regularly write deeply nested bullet point lists you notice it happening about 1 of 25 times. Nothing tragic, but mildly annoying.

Ohne Titel 2020-06-02 23_43_31

Is there any error message in the console?

No.

@yzhang-gh
Copy link
Owner

Can you disable all other extensions and try again? It works stably on my PC. (Your line numbers looks different from a regular setting.)

@dschuessler
Copy link
Author

dschuessler commented Jun 7, 2020

I actually failed to reproduce this with extensions turned off. I used to use the Vim extension and since switched to https://github.com/asvetliakov/vscode-neovim which seemingly fixed the issue, but right now it happened again.

I don't know how possibly to check the influence of every extension I use on the frequency of this issue. I guess somewhere deep down there is some kind of race condition.

@yzhang-gh
Copy link
Owner

I guess the Vim extension is the reason as both it and this extension listen to the "onEnterKey" event and do some edits according to the context. This extension tries to avoid such a conflict by checking the Vim mode

"when": "editorTextFocus && !editorReadonly && editorLangId == markdown && !suggestWidgetVisible && vim.mode != 'Normal' && vim.mode != 'Visual' && vim.mode != 'VisualBlock' && vim.mode != 'VisualLine' && vim.mode != 'SearchInProgressMode' && vim.mode != 'CommandlineInProgress' && vim.mode != 'Replace' && vim.mode != 'EasyMotionMode' && vim.mode != 'EasyMotionInputMode' && vim.mode != 'SurroundInputMode'"

vim.mode != 'Normal' && vim.mode != 'Visual' && vim.mode != 'VisualBlock' && vim.mode != 'VisualLine' && vim.mode != 'SearchInProgressMode' && vim.mode != 'CommandlineInProgress' && vim.mode != 'Replace' && vim.mode != 'EasyMotionMode' && vim.mode != 'EasyMotionInputMode' && vim.mode != 'SurroundInputMode'


I realized you are using asvetliakov.vscode-neovim rather than vscodevim.vim

Please also check https://github.com/asvetliakov/vscode-neovim#performancelatency-problems. It is common that a Vim extension conflicts with some extensions because of the mechanism.

@dschuessler
Copy link
Author

I see. Do I understand correctly that it is out of the control of extension authors to address such behavior? In that case I’d try escalating the issue to the VSCode maintainers as it would be framed more aptly as an issue with the extension system rather than a particular extension.

@yzhang-gh
Copy link
Owner

Do I understand correctly that it is out of the control of extension authors to address such behavior?

Exactly. For a single extension, it overrides any key it wants to change. Usually different extensions won't conflict as we have context variables. However, I guess the context updating cannot catch up with your typing speed in this case.

In that case I’d try escalating the issue to the VSCode maintainers as it would be framed more aptly as an issue with the extension system rather than a particular extension.

I agree although I don't think there is a good solution now (and it is hard to tell what VSCode should do to improve this situation). The Vim extensions are eventually simulators on VSCode and some performance(-related/caused) issues are expected.

@yzhang-gh
Copy link
Owner

Close as there is not much we can do on this side.

@yzhang-gh yzhang-gh added Upstream Pertaining to an upstream component, or blocked by an upstream issue. Issue: Performance The ability to respond to user actions quickly. Diagnosis requires expertise and detailed info. and removed Needs More Info labels Jun 20, 2020
@Lemmingh Lemmingh added Area: Input Related to editor input processing (key presses, key bindings). Res: External Outside of our control/codebase. Area: List editing List editing: continuation, numbering, toggling, etc. labels Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Input Related to editor input processing (key presses, key bindings). Area: List editing List editing: continuation, numbering, toggling, etc. Issue: Performance The ability to respond to user actions quickly. Diagnosis requires expertise and detailed info. Res: External Outside of our control/codebase. Upstream Pertaining to an upstream component, or blocked by an upstream issue.
Projects
None yet
Development

No branches or pull requests

3 participants