Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support container secrets #458

Closed
rockaut opened this issue May 2, 2019 · 1 comment
Closed

Support container secrets #458

rockaut opened this issue May 2, 2019 · 1 comment

Comments

@rockaut
Copy link

rockaut commented May 2, 2019

It would be great if Zabbix could also support using container secrets. Currently the common implementation is to look at _FILE environment variables and if there are some use that provided file for reading the environment variable.

For example with POSTGRES_PASSWORD:
If the env variable POSTGRES_PASSWORD_FILE is set read the contents of the POSTGRES_PASSWORD_FILE into POSTGRES_PASSWORD environment variable (even overwriting already set POSTGRES_PASSWORD).

Also look at implementation in grafana for example: https://grafana.com/docs/installation/docker/#reading-secrets-from-files-support-for-docker-secrets and grafana/grafana-docker#166
By the way - Postgres is already supporting this in their containers!

@dotneft
Copy link
Collaborator

dotneft commented Jul 13, 2019

Added

@dotneft dotneft closed this as completed Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants