fix: maximize chance of reusing the connection while updating #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we would gather which would open a flood of connections
bdraco
changed the title
|
Thanks. Did you notice any 408s or connection errors previously? I may consider it a fix in that case. |
|
It went unavailable frequently before this change, but I didn't realize that until I looked at the history that they went away so I didn't put it in the comments as I didn't connect it until you asked |
alandtse
changed the title
alandtse
added a commit
that referenced
this pull request
Feb 23, 2024
fix: maximize chance of reusing the connection while updating (#456)
|
Thanks. That's good enough for me to make it a fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would gather which would open a flood of connections and since the cost of establishing the TLS connection
do_handshakewas higher than the actual request, it would take more wall clock time to update and was more resource intensive.