Upgrade H3 core to v4
#54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachasme
force-pushed
the
breaking-v4
branch
4 times, most recently
from
02adea5
to
a9cd8cc
Compare
zachasme
force-pushed
the
breaking-v4
branch
2 times, most recently
from
444381b
to
cdd55a9
Compare
|
FYI we're planning to release v4.0.0 fairly soon (uber/h3#633) - great to see this be picked up in the Postgres bindings |
Rename functions in sql, c and tests. Also remove deprecated functions. Still need to figure out upgrade strategy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for aligning with H3 core v4, while they work on finalizing naming and APIs.
I've renamed functions in SQL and C, as well as updated tests. Deprecated functions has been removed.
We should consider the upgrade strategy. We had an issue earlier when adding support for pass-by-value which broke data on upgrade. We could opt not to include an upgrade script in the base extension. We could also use this opportunity to split the PostGIS integration into a separate "h3-postgis" extension.