Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows support using CMake #70

Merged
merged 3 commits into from
Nov 4, 2022
Merged

Windows support using CMake #70

merged 3 commits into from
Nov 4, 2022

Conversation

zachasme
Copy link
Owner

@zachasme zachasme commented Apr 13, 2022

This PR builds the entire project using CMake instead of PGXS.

I think this is a good idea since CMake is already a hard dependency from H3, and it makes it easier to build and install h3-pg on both Windows and MacOS.

There are still a few things I'd like to figure out:

@zachasme zachasme marked this pull request as draft April 13, 2022 10:44
@zachasme zachasme changed the title WIP: Windows support using CMake Windows support using CMake Oct 10, 2022
@zachasme zachasme self-assigned this Oct 11, 2022
@zachasme zachasme force-pushed the cmake branch 10 times, most recently from d80cc09 to 43ce077 Compare October 12, 2022 12:23
@zachasme zachasme added the enhancement 🚀 New feature or request label Nov 2, 2022
@zachasme
Copy link
Owner Author

zachasme commented Nov 2, 2022

I've been working on this for a while, as part of providing h3-pg for a Windows user, and I think it is ready for testing and/or input if anyone has views on this rather large change.

@Komzpa, @mngr777 do any of you guys have any thoughts on this? I'm hoping to wrap it in the Makefile so it should keep working with pgxn. How are you currently installing h3-pg?

@zachasme zachasme marked this pull request as ready for review November 2, 2022 16:59
@Komzpa
Copy link
Contributor

Komzpa commented Nov 3, 2022

@zachasme we use pgxn install h3 on linux boxes.

@zachasme zachasme merged commit e43d415 into main Nov 4, 2022
@zachasme zachasme deleted the cmake branch November 4, 2022 12:24
zachasme added a commit that referenced this pull request Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🚀 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants