Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to change == to = #1

Open
brianjohnson5972 opened this issue Feb 23, 2022 · 1 comment
Open

Need to change == to = #1

brianjohnson5972 opened this issue Feb 23, 2022 · 1 comment
Assignees
@zachdbertram

Comments

@brianjohnson5972
Copy link

In MortgagePayment.sol lines 54, 62 and 68 you should be using = instead of ==.

At line 67 it looks like you hare having the buyer transfer to the buyer.

Adding a unit test would make the use cases here much more clear and prove that it works.
@zachdbertram zachdbertram self-assigned this Mar 7, 2022
@zachdbertram
Copy link
Owner

Hi @brianjohnson5972 thank you for your suggestions regarding the = vs. == typos on lines 54, 62, and 68. You are correct about line 67 of the original contract code. The issues you have brought to my attention are not the only issues of the original contract, and I decided to revamp the code after a lot of troubleshooting. I will be attaching a pull request with the new contract code and would appreciate your input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zachdbertram zachdbertram

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

1-need-to-change-==-to-= zachdbertram/MortgagePayment
2 participants
@brianjohnson5972 @zachdbertram