Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ionicMaterialInk.displayEffect() : use options.selector when defined #220

Open
blavenie opened this issue Mar 13, 2017 · 0 comments · May be fixed by #221
Open

ionicMaterialInk.displayEffect() : use options.selector when defined #220

blavenie opened this issue Mar 13, 2017 · 0 comments · May be fixed by #221

Comments

@blavenie
Copy link

DESCRIPTION

Be able to display ink effectes on a selection of element

When using ionicMaterialInk.displayEffect on controller, some .ink elements are update more than once.
This is not well optimized, specially when using list with inked items.

EXPECTED

If not undefined, options.selector is used to select inked elements.
@blavenie blavenie changed the title ionicMaterialInk.displayEffect() : use options.selector when defined ionicMaterialInk.displayEffect() : use options.selector when defined Mar 13, 2017
blavenie added a commit to e-is/Ionic-Material that referenced this issue Mar 13, 2017
@blavenie
ionicMaterialInk.displayEffect() : use options.selector when defined -
1f4e035 
fix zachfitz#220
@blavenie blavenie linked a pull request Mar 13, 2017 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ionicMaterialInk.displayEffect() : use options.selector when defined… e-is/Ionic-Material
1 participant
@blavenie