Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setext-style Headers Cause Editor to Break #155

Open
2 tasks done
zachhannum opened this issue Oct 7, 2022 · 0 comments
Open
2 tasks done

Setext-style Headers Cause Editor to Break #155

zachhannum opened this issue Oct 7, 2022 · 0 comments
Labels
bug Something isn't working editor
Milestone

Comments

@zachhannum
Copy link
Owner

zachhannum commented Oct 7, 2022

Prerequisites

Expected Behavior

Editor Functions as expected.

Current Behavior

Using Setext-style Headers causes the Editor to function in unexpected ways.

2022-10-07.08-57-58.mp4

Steps to Reproduce

  1. Use Setext-style headers in the document editor

  2. Press enter to trigger Header line decoration

  3. Type more stuff

  4. Try to backspace/highlight to delete text.

Possible Solution (Not obligatory)

My guess is this has to do with the widget decorations used to hide and decorate ATX style header markup, which does not work effectively with Setext-style headers. See app/renderer/components/codemirror/extensions/hideMarkdown.ts for where we do the markup replacement. See the codemirror documentation for how this works.

@zachhannum zachhannum added the bug Something isn't working label Oct 7, 2022
@zachhannum zachhannum added this to the v1 milestone Oct 7, 2022
@zachhannum zachhannum added this to Orca Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working editor
Projects
Status: No status
Development

No branches or pull requests

1 participant