fix zadam/trilium#3630

zadam · Feb 22, 2023 · 1934c4b · 1934c4b
1 parent 4c19ef1
commit 1934c4b
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/packages/ckeditor5-build-balloon-block/build-and-update.sh b/packages/ckeditor5-build-balloon-block/build-and-update.sh
@@ -2,12 +2,15 @@
 
 rm -rf node_modules/@ckeditor/ckeditor5-mention
 rm -rf node_modules/@ckeditor/ckeditor5-find-and-replace
+rm -rf node_modules/@ckeditor/ckeditor5-link
 mkdir node_modules
 # force usage of local modification
 # mention contains changes to support the attribute editor
 cp -r ../ckeditor5-mention node_modules/@ckeditor/
 # find and replace disables keyboard shortcut so that it doesn't override trilium find widget
 cp -r ../ckeditor5-find-and-replace node_modules/@ckeditor/
+# link binds by ctrl+click to open the link which conflicts with trilium handling
+cp -r ../ckeditor5-link node_modules/@ckeditor/
 
 npm run build
 

diff --git a/packages/ckeditor5-build-balloon-block/build/ckeditor.js b/packages/ckeditor5-build-balloon-block/build/ckeditor.js
diff --git a/packages/ckeditor5-build-balloon-block/build/ckeditor.js.map b/packages/ckeditor5-build-balloon-block/build/ckeditor.js.map
diff --git a/packages/ckeditor5-link/src/linkediting.js b/packages/ckeditor5-link/src/linkediting.js
@@ -107,8 +107,9 @@ export default class LinkEditing extends Plugin {
 		// Setup highlight over selected link.
 		inlineHighlight( editor, 'linkHref', 'a', HIGHLIGHT_CLASS );
 
+		// hack to fix https://github.com/zadam/trilium/issues/3630
 		// Handle link following by CTRL+click or ALT+ENTER
-		this._enableLinkOpen();
+		// this._enableLinkOpen();
 
 		// Change the attributes of the selection in certain situations after the link was inserted into the document.
 		this._enableInsertContentSelectionAttributesFixer();