Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If consistency check runs in the middle of sync it can report inconsistencies #2

Closed
zadam opened this issue Dec 27, 2017 · 1 comment
Closed

If consistency check runs in the middle of sync it can report inconsistencies #2

zadam opened this issue Dec 27, 2017 · 1 comment

Comments

@zadam
Copy link
Owner

zadam commented Dec 27, 2017

Ultimately we need better sync protocol, but in the mean time fix would be to wait for the sync to finish and only then start consistency checks.
@zadam
Copy link
Owner Author

zadam commented Jan 5, 2018

Fixed in 663bd1a by adding a sync mutex so consistency check waits for the sync to finish.

@zadam zadam closed this as completed Jan 5, 2018
@4asifm 4asifm mentioned this issue Jun 6, 2020
Closed
This was referenced Nov 24, 2022
Closed
Closed
zadam pushed a commit that referenced this issue Nov 12, 2023
@ljgonzalez1
Merge pull request #2
fb1478f 
Add OS and IDE files to the gitignore + Add documentation
zadam pushed a commit that referenced this issue Nov 12, 2023
@ljgonzalez1
Revert "🙈 gitignore" commits.
e25c86e 
This reverts commits 30bd216, 9a587e8, 38e6008, 5af1c77 and c8d6f20.

It reverts pr #2 from my branch
@Alumniminium Alumniminium mentioned this issue Feb 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zadam